Use https in the Github shortcut by default in Bundler 2 #6798

colby-swandale · 2018-11-22T04:47:58Z

This PR is setting Git gems to be fetched over https by default.

Note: This PR is successing #6791

colby-swandale · 2018-11-22T04:49:21Z

Note that for this to me merged into master i couldn't check for https outside of the :bundler => "< 2" scope. But this can be cleaned up once 2.0.0 is released.

lib/bundler/feature_flag.rb

deivid-rodriguez · 2018-11-22T10:13:44Z

lib/bundler/settings.rb

@@ -35,6 +35,7 @@ class Settings
      frozen
      gem.coc
      gem.mit
+      github_https


This is the list of settings, not feature flags, so the . should be used here, right?

spec/quality_spec.rb

segiddins · 2018-11-24T18:02:22Z

lib/bundler/feature_flag.rb

@@ -64,6 +64,12 @@ def initialize(bundler_version)
      @bundler_version = Gem::Version.create(bundler_version)
    end

+    def github_https


github_https?

This could also probably be

settings_method(:github_https?, "github.https") { bundler_2_mode? }

That way you don't have to replicate the logic

oh awesome, i didn't realize that. Thanks!

lib/bundler/feature_flag.rb

colby-swandale · 2018-11-26T23:09:24Z

@bundlerbot r+

6798: Use https in the Github shortcut by default in Bundler 2 r=colby-swandale a=colby-swandale This PR is setting Git gems to be fetched over https by default. Note: This PR is successing #6791 Closes #6785 Co-authored-by: Colby Swandale <[email protected]>

ghost · 2018-11-26T23:44:39Z

Build succeeded

continuous-integration/travis-ci/push

6798: Use https in the Github shortcut by default in Bundler 2 r=colby-swandale a=colby-swandale This PR is setting Git gems to be fetched over https by default. Note: This PR is successing #6791 Closes #6785 Co-authored-by: Colby Swandale <[email protected]> (cherry picked from commit cf45792)

* 1-17-stable: Version 1.17.2 with changelog Merge #6798 Merge #6818 Merge #6786 Merge #6743 Merge #6742 Merge #6740 Merge #6834 Merge pull request #6752 from bundler/indirect/backport-6737

6798: Use https in the Github shortcut by default in Bundler 2 r=colby-swandale a=colby-swandale This PR is setting Git gems to be fetched over https by default. Note: This PR is successing #6791 Closes #6785 Co-authored-by: Colby Swandale <[email protected]> (cherry picked from commit cf45792)

7182: Merge #6798 into `2-0-stable` r=colby-swandale a=colby-swandale ### What was the end-user problem that led to this PR? The PR #6798 was not merged correctly in the `2.0.0` release. This was my fault. This PR resolves this. ### What is your fix for the problem, implemented in this PR? Re-merge the PR back into the `2-0-stable` branch. Co-authored-by: Bundlerbot <[email protected]> Co-authored-by: Colby Swandale <[email protected]>

Merge #6798 into `2-0-stable`

* 2-0-stable: (89 commits) fix changelog 2.0.2 typos add v2.0.2 changelog bump version to 2.0.2 Merge #7199 fix bug where bundler v3 is running a test for bundflet 2 Merge #6798 add bors configuation port GemHelper from master Merge #7080 Merge #7089 Merge #7068 Merge #7036 Merge #7067 change Bundler 3 specs in travis to use RubyGems 3.0.3 bump RubyGems v3 to the latest version on Travis Merge #6963 Merge #7078 Merge pull request #7061 from bundler/fix_circular_requires Merge #6864 remove linting step in travis (it will still run in each build) ...

jordanmichaelrushing · 2019-06-13T21:06:25Z

Well that latest merge just screwed us over for about 5 hours. If there's any googlers out there with deployments that are now all of a sudden broken, it's because your source is changing from git to https on deployment and your local was expecting git. So rebuild your gemfile.lock again locally and you should be fine.
Specifically locally I changed any instance of github: to git:and re bundled. But as long as you rebundle locally, you should be fine. Your mileage may very. GL

indirect · 2019-06-14T03:06:08Z

@jordanmichaelrushing Hi.

First, the meta: we have a code of conduct, and the language in your message isn't okay. Please reword your message to be less shitty towards the people who put a huge amount of effort into providing you with Bundler, for free.

Second, to your point about "sudden" breakage: Bundler has been printing out warnings about this change for literally years. More than one. Your application may have broken suddenly, in a way that surprised you, but this change in Bundler was not sudden.

colby-swandale force-pushed the colby/git-https-default branch 2 times, most recently from e693896 to 15173fa Compare November 22, 2018 09:58

deivid-rodriguez reviewed Nov 22, 2018

View reviewed changes

lib/bundler/feature_flag.rb Outdated Show resolved Hide resolved

deivid-rodriguez reviewed Nov 22, 2018

View reviewed changes

colby-swandale force-pushed the colby/git-https-default branch 2 times, most recently from 96216eb to 332741a Compare November 23, 2018 04:51

deivid-rodriguez reviewed Nov 23, 2018

View reviewed changes

spec/quality_spec.rb Outdated Show resolved Hide resolved

colby-swandale force-pushed the colby/git-https-default branch 4 times, most recently from 0cbfa40 to 0718454 Compare November 23, 2018 11:20

segiddins reviewed Nov 24, 2018

View reviewed changes

add feature flag to use https for :git in the dsl

93471b0

colby-swandale force-pushed the colby/git-https-default branch from 0718454 to 93471b0 Compare November 24, 2018 20:58

segiddins approved these changes Nov 25, 2018

View reviewed changes

deivid-rodriguez reviewed Nov 26, 2018

View reviewed changes

lib/bundler/feature_flag.rb Show resolved Hide resolved

deivid-rodriguez approved these changes Nov 26, 2018

View reviewed changes

ghost merged commit 93471b0 into master Nov 26, 2018

ghost deleted the colby/git-https-default branch November 26, 2018 23:44

knu mentioned this pull request Jan 7, 2019

Fix CI huginn/huginn#2453

Closed

colby-swandale added this to the 2.0.0 milestone Feb 25, 2019

colby-swandale mentioned this pull request May 28, 2019

Merge #6798 into 2-0-stable #7182

Merged

colby-swandale added a commit that referenced this pull request Jun 12, 2019

Merge #6798 into 2-0-stable (#7182)

293d743

Merge #6798 into `2-0-stable`

rubygems locked and limited conversation to collaborators Jun 14, 2019

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use https in the Github shortcut by default in Bundler 2 #6798

Use https in the Github shortcut by default in Bundler 2 #6798

colby-swandale commented Nov 22, 2018

colby-swandale commented Nov 22, 2018

deivid-rodriguez Nov 22, 2018

segiddins Nov 24, 2018

segiddins Nov 24, 2018

colby-swandale Nov 24, 2018

colby-swandale commented Nov 26, 2018

ghost commented Nov 26, 2018

jordanmichaelrushing commented Jun 13, 2019 •

edited

Loading

indirect commented Jun 14, 2019

Use https in the Github shortcut by default in Bundler 2 #6798

Use https in the Github shortcut by default in Bundler 2 #6798

Conversation

colby-swandale commented Nov 22, 2018

colby-swandale commented Nov 22, 2018

deivid-rodriguez Nov 22, 2018

Choose a reason for hiding this comment

segiddins Nov 24, 2018

Choose a reason for hiding this comment

segiddins Nov 24, 2018

Choose a reason for hiding this comment

colby-swandale Nov 24, 2018

Choose a reason for hiding this comment

colby-swandale commented Nov 26, 2018

ghost commented Nov 26, 2018

Build succeeded

jordanmichaelrushing commented Jun 13, 2019 • edited Loading

indirect commented Jun 14, 2019

jordanmichaelrushing commented Jun 13, 2019 •

edited

Loading