This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Bump travis rubies #7036
Merged
Bump travis rubies #7036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Restarted the build. Seems that the tgz for Ruby 2.6.2 wasn't up at the time of opening the PR. |
colby-swandale
approved these changes
Mar 14, 2019
|
I still need to restore some of the hacks. The |
deivid-rodriguez
force-pushed
the
bump_travis_rubies
branch
3 times, most recently
from
39c9a16 to
d3095df
Compare
MRI 2.5.4 now regressed and suffers from the same issue as 2.6.2 :S
deivid-rodriguez
force-pushed
the
bump_travis_rubies
branch
from
d3095df to
15976c0
Compare
To avoid activation of the `etc` gem.
|
Hei! I managed to get this green and removed all hacks. After closer examination, it might be This sounds like a better fix. It needs a patch to |
|
We should wait for the upstream PR, @hsbt could you have a look? |
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Mar 27, 2019
7036: Bump travis rubies r=hsbt a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that hacks create confusion, even if they include TODO notes. ### What was your diagnosis of the problem? My diagnosis was that we can should upgrade to the latest ruby releases to reduce the number of hacks we need to maintain. ### What is your fix for the problem, implemented in this PR? My fix is to upgrade rubies and remove hacks. ### Why did you choose this fix out of the possible options? I chose this fix because it's a good change. Co-authored-by: David Rodríguez <[email protected]>
Build succeeded |
ghost
merged commit
|
Great! I opened #7068 to vendor that! |
colby-swandale
pushed a commit
that referenced
this pull request
Apr 5, 2019
7036: Bump travis rubies r=hsbt a=deivid-rodriguez The problem was that hacks create confusion, even if they include TODO notes. My diagnosis was that we can should upgrade to the latest ruby releases to reduce the number of hacks we need to maintain. My fix is to upgrade rubies and remove hacks. I chose this fix because it's a good change. Co-authored-by: David Rodríguez <[email protected]> (cherry picked from commit d368aa9)
colby-swandale
added a commit
that referenced
this pull request
Jun 13, 2019
* 2-0-stable: (89 commits) fix changelog 2.0.2 typos add v2.0.2 changelog bump version to 2.0.2 Merge #7199 fix bug where bundler v3 is running a test for bundflet 2 Merge #6798 add bors configuation port GemHelper from master Merge #7080 Merge #7089 Merge #7068 Merge #7036 Merge #7067 change Bundler 3 specs in travis to use RubyGems 3.0.3 bump RubyGems v3 to the latest version on Travis Merge #6963 Merge #7078 Merge pull request #7061 from bundler/fix_circular_requires Merge #6864 remove linting step in travis (it will still run in each build) ...
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was that hacks create confusion, even if they include TODO notes.
What was your diagnosis of the problem?
My diagnosis was that we can should upgrade to the latest ruby releases to reduce the number of hacks we need to maintain.
What is your fix for the problem, implemented in this PR?
My fix is to upgrade rubies and remove hacks.
Why did you choose this fix out of the possible options?
I chose this fix because it's a good change.