This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Try fix azure flakyness #7033
Merged
Try fix azure flakyness #7033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These failures kind of failure last happened at #7030. See https://dev.azure.com/bundler/0e797e3c-1d87-40b4-ae08-813af36de214/_build/results?buildId=472. |
|
Merging this because I just got another timeout on #7037. @bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Mar 14, 2019
7033: Try fix azure flakyness r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that sometimes Azure is timing out. My guess is that this is not Azure slowness, but the big amount of failures currently present on the Windows build making it very slow. ### What was your diagnosis of the problem? My diagnosis was that we don't want red Azure builds for now, since we don't yet really fully support Windows. ### What is your fix for the problem, implemented in this PR? My fix is to wrap the job that runs the specs with a [bash timeout](https://linux.die.net/man/1/timeout) with a limit under Azure's one hour limit. ### Why did you choose this fix out of the possible options? I chose this fix because I think it should prevent Azure statuses from getting in the middle for now. Co-authored-by: David Rodríguez <[email protected]>
Build succeeded |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was that sometimes Azure is timing out. My guess is that this is not Azure slowness, but the big amount of failures currently present on the Windows build making it very slow.
What was your diagnosis of the problem?
My diagnosis was that we don't want red Azure builds for now, since we don't yet really fully support Windows.
What is your fix for the problem, implemented in this PR?
My fix is to wrap the job that runs the specs with a bash timeout with a limit under Azure's one hour limit.
Why did you choose this fix out of the possible options?
I chose this fix because I think it should prevent Azure statuses from getting in the middle for now.