Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Commit

Permalink
Merge #7033
Browse files Browse the repository at this point in the history
7033: Try fix azure flakyness r=deivid-rodriguez a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The problem was that sometimes Azure is timing out. My guess is that this is not Azure slowness, but the big amount of failures currently present on the Windows build making it very slow.

### What was your diagnosis of the problem?

My diagnosis was that we don't want red Azure builds for now, since we don't yet really fully support Windows.

### What is your fix for the problem, implemented in this PR?

My fix is to wrap the job that runs the specs with a [bash timeout](https://linux.die.net/man/1/timeout) with a limit under Azure's one hour limit. 

### Why did you choose this fix out of the possible options?

I chose this fix because I think it should prevent Azure statuses from getting in the middle for now.


Co-authored-by: David Rodríguez <[email protected]>
  • Loading branch information
bundlerbot and deivid-rodriguez committed Mar 14, 2019
2 parents b65b075 + 30ad6bc commit 236ccf7
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .azure-pipelines/steps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ steps:
- script: |
ruby bin/rake spec:deps
displayName: 'ruby bin/rake spec:deps'

- script: |
gem install --no-document --conservative rspec_junit_formatter
displayName: 'gem install rspec_junit_formatter'

- script: |
ruby -r rspec_junit_formatter bin/rspec --format progress --format RspecJunitFormatter -o rspec/bundler-junit-results.xml || exit 0
timeout 50m bash -c 'ruby -r rspec_junit_formatter bin/rspec --format progress --format RspecJunitFormatter -o rspec/bundler-junit-results.xml' || exit 0
displayName: 'ruby bin/rspec'

- task: PublishTestResults@2
Expand Down

0 comments on commit 236ccf7

Please sign in to comment.