This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Remove LessThanProc
#7030
Merged
Remove LessThanProc
#7030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
remove_less_than_proc
branch
from
3a06f47 to
89d8e47
Compare
deivid-rodriguez
force-pushed
the
remove_less_than_proc
branch
from
89d8e47 to
30fa1db
Compare
colby-swandale
approved these changes
Mar 15, 2019
|
Thanks @colby-swandale! @bundlerbot r=colby-swandale |
ghost
pushed a commit
that referenced
this pull request
Mar 15, 2019
7030: Remove `LessThanProc` r=colby-swandale a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that the `LessThanProc` class we use for filtering specs is confusing, in my opinion. For example, if I tag a spec with `:bundler => "2"`, I would expect it to run only against bundler 2. However, that's not how it works, it instead runs against any bundler higher than or equal to 2. ### What was your diagnosis of the problem? My diagnosis was that the `LessThanProc` class could be much simpler, and just check that the passed requirement matches the version the class was created with. ### What is your fix for the problem, implemented in this PR? My fix is to simplify the `LessThanProc` class to only do requirement matching, and remove the "less than" functionality. ### Why did you choose this fix out of the possible options? I chose this fix because in my opinion it's simpler to understand and less surprising. Co-authored-by: David Rodríguez <[email protected]>
Build succeeded |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was that the
LessThanProcclass we use for filtering specs is confusing, in my opinion. For example, if I tag a spec with:bundler => "2", I would expect it to run only against bundler 2. However, that's not how it works, it instead runs against any bundler higher than or equal to 2.What was your diagnosis of the problem?
My diagnosis was that the
LessThanProcclass could be much simpler, and just check that the passed requirement matches the version the class was created with.What is your fix for the problem, implemented in this PR?
My fix is to simplify the
LessThanProcclass to only do requirement matching, and remove the "less than" functionality.Why did you choose this fix out of the possible options?
I chose this fix because in my opinion it's simpler to understand and less surprising.