Update the maintainer to me. #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Lalancette <[email protected]>
mikaelarguedas
previously requested changes
Dec 8, 2017
There was a problem hiding this comment.
Please update the setup.py too
teleop_twist_keyboard/setup.py
Line 18 in dc80cae
Signed-off-by: Chris Lalancette <[email protected]>
setup.py
Outdated
| maintainer='Chris Lalancette', | ||
| maintainer_email='[email protected]', | ||
| author='Graylin Trevor Jay, Austin Hendrix', | ||
| author_email='[email protected]', |
There was a problem hiding this comment.
not sure if setup.py likes a different number of author and author_email. Id suggest to ditch the email field as there is no way to know which author it belongs to
Signed-off-by: Chris Lalancette <[email protected]>
package.xml
Outdated
| <license>BSD License 2.0</license> | ||
| <description> | ||
| A robot-agnostic teleoperation node to convert keyboard commands to Twist | ||
| messages. | ||
| </description> | ||
|
|
||
| <maintainer email="[email protected]">Austin Hendrix</maintainer> | ||
| <maintainer email="[email protected]">Chris Lalancette</maintainer> | ||
| <author email="[email protected]">Austin Hendrix</author> |
There was a problem hiding this comment.
authors should be moved lower and url updated
mikaelarguedas
added
in review
mikaelarguedas
pushed a commit
that referenced
this pull request
May 24, 2018
* Update the maintainer to me. * Update setup.py. * Remove author email. * fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chris Lalancette [email protected]