Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update boost keys for Debian and Ubuntu. #31559

Merged
merged 16 commits into from
Jan 6, 2022
Merged

Update boost keys for Debian and Ubuntu. #31559

merged 16 commits into from
Jan 6, 2022

Conversation

nuclearsandwich
Copy link
Member

  • boost
    • Use libboost-dev-all package for all Debian distributions.
    • Use libboost-dev-all package for all Ubuntu distributions.
  • libboost-atomic
    • Add Debian Bullseye definition.
    • Drop Debian Stretch definition.
    • Add Ubuntu Jammy definition.
    • Drop Ubuntu Xenial definition.
  • libboost-chrono
    • Add Debian Bullseye definition.
    • Drop Debian Stretch definition.
    • Add Ubuntu Jammy definition.
    • Drop Ubuntu Xenial definition.
  • libboost-date-time
    • Add Debian Bullseye definition.
    • Drop Debian Stretch definition.
    • Add Ubuntu Jammy definition.
    • Drop Ubuntu Xenial definition.
  • libboost-filesystem
    • Add Debian Bullseye definition.
    • Drop Debian Stretch definition.
    • Add Ubuntu Jammy definition.
    • Drop Ubuntu Xenial definition.
  • libboost-iostreams
    • Add Debian Bullseye definition.
    • Drop Debian Stretch definition.
    • Add Ubuntu Jammy definition.
    • Drop Ubuntu Xenial definition.
  • libboost-math
    • Add Debian Bullseye definition.
    • Drop Debian Stretch definition.
    • Add Ubuntu Jammy definition.
    • Drop Ubuntu Xenial definition.
  • libboost-program-options
    • Add Debian Bullseye definition.
    • Drop Debian Stretch definition.
    • Drop Debian Jessie definition.
    • Add Ubuntu Jammy definition.
    • Drop Ubuntu Xenial definition.
    • Drop Ubuntu Trusty definition.
  • libboost-python
    • Add Debian Bullseye definition.
    • Drop Debian Stretch definition.
    • Drop Debian Jessie definition.
    • Add Ubuntu Jammy definition.
    • Drop Ubuntu Xenial definition.
    • Drop Ubuntu Trusty definition.
  • libboost-random
    • Add Debian Bullseye definition.
    • Drop Debian Stretch definition.
    • Drop Debian Jessie definition.
    • Drop Debian Wheezy definition.
    • Add Ubuntu Jammy definition.
    • Drop Ubuntu Xenial definition.
    • Drop Ubuntu Trusty definition.
    • Drop Ubuntu Precise definition.
  • libboost-regex
    • Add Debian Bullseye definition.
    • Drop Debian Stretch definition.
    • Add Ubuntu Jammy definition.
    • Drop Ubuntu Xenial definition.
  • libboost-serialization
    • Add Debian Bullseye definition.
    • Drop Debian Stretch definition.
    • Add Ubuntu Jammy definition.
    • Drop Ubuntu Xenial definition.
  • libboost-system
    • Add Debian Bullseye definition.
    • Drop Debian Stretch definition.
    • Add Ubuntu Jammy definition.
    • Drop Ubuntu Xenial definition.
    • Drop Ubuntu Trusty definition.
  • libboost-thread
    • Add Debian Bullseye definition.
    • Drop Debian Stretch definition.
    • Add Ubuntu Jammy definition.
    • Drop Ubuntu Xenial definition.
    • Drop Ubuntu Trusty definition.
  • libboost-timer
    • Add Debian Bullseye definition.
    • Drop Debian Stretch definition.
    • Add Ubuntu Jammy definition.
    • Drop Ubuntu Xenial definition.

@nuclearsandwich nuclearsandwich added the rosdep Issue/PR is for a rosdep key label Dec 23, 2021
@nuclearsandwich nuclearsandwich self-assigned this Dec 23, 2021
@nuclearsandwich nuclearsandwich requested a review from a team as a code owner December 23, 2021 04:01
clalancette
clalancette reviewed Jan 5, 2022
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here about removing the xenial keys; I think we agreed to keep them for now.

tfoote
tfoote approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re xenial: We talked about it in #31569 and have guidance for how to use older tags. I'd suggest that we go ahead and remove them.

@nuclearsandwich
Update boost key.
05ed230 
* Use `libboost-dev-all` package for all Debian distributions.
* Use `libboost-dev-all` package for all Ubuntu distributions.
@nuclearsandwich
Update libboost-atomic key.
93edc16 
* Add Debian Bullseye definition.
* Drop Debian Stretch definition.
* Add Ubuntu Jammy definition.
* Drop Ubuntu Xenial definition.
@nuclearsandwich
Update libboost-chrono key.
b3923c0 
* Add Debian Bullseye definition.
* Drop Debian Stretch definition.
* Add Ubuntu Jammy definition.
* Drop Ubuntu Xenial definition.
@nuclearsandwich
Update libboost-date-time key.
c2e67f6 
* Add Debian Bullseye definition.
* Drop Debian Stretch definition.
* Add Ubuntu Jammy definition.
* Drop Ubuntu Xenial definition.
@nuclearsandwich
Update libboost-filesystem key.
49d97dd 
* Add Debian Bullseye definition.
* Drop Debian Stretch definition.
* Add Ubuntu Jammy definition.
* Drop Ubuntu Xenial definition.
@nuclearsandwich
Update libboost-iostreams key.
95d2c14 
* Add Debian Bullseye definition.
* Drop Debian Stretch definition.
* Add Ubuntu Jammy definition.
* Drop Ubuntu Xenial definition.
@nuclearsandwich
Update libboost-math key.
c65b356 
* Add Debian Bullseye definition.
* Drop Debian Stretch definition.
* Add Ubuntu Jammy definition.
* Drop Ubuntu Xenial definition.
@nuclearsandwich
Update libboost-program-options key.
7159fbe 
* Add Debian Bullseye definition.
* Drop Debian Stretch definition.
* Drop Debian Jessie definition.
* Add Ubuntu Jammy definition.
* Drop Ubuntu Xenial definition.
* Drop Ubuntu Trusty definition.
@nuclearsandwich
Update libboost-python key.
75e8cf5 
* Add Debian Bullseye definition.
* Drop Debian Stretch definition.
* Drop Debian Jessie definition.
* Add Ubuntu Jammy definition.
* Drop Ubuntu Xenial definition.
* Drop Ubuntu Trusty definition.
@nuclearsandwich
Update libboost-random key.
19f9bce 
* Add Debian Bullseye definition.
* Drop Debian Stretch definition.
* Drop Debian Jessie definition.
* Drop Debian Wheezy definition.
* Add Ubuntu Jammy definition.
* Drop Ubuntu Xenial definition.
* Drop Ubuntu Trusty definition.
* Drop Ubuntu Precise definition.
@nuclearsandwich
Update libboost-regex key.
dd1343e 
* Add Debian Bullseye definition.
* Drop Debian Stretch definition.
* Add Ubuntu Jammy definition.
* Drop Ubuntu Xenial definition.
@nuclearsandwich
Update libboost-serialization key.
1ea4096 
* Add Debian Bullseye definition.
* Drop Debian Stretch definition.
* Add Ubuntu Jammy definition.
* Drop Ubuntu Xenial definition.
@nuclearsandwich
Update libboost-system key.
260c54d 
* Add Debian Bullseye definition.
* Drop Debian Stretch definition.
* Add Ubuntu Jammy definition.
* Drop Ubuntu Xenial definition.
* Drop Ubuntu Trusty definition.
@nuclearsandwich
Update libboost-thread key.
d3f9540 
* Add Debian Bullseye definition.
* Drop Debian Stretch definition.
* Add Ubuntu Jammy definition.
* Drop Ubuntu Xenial definition.
* Drop Ubuntu Trusty definition.
@nuclearsandwich
Update libboost-timer key.
d868a1f 
* Add Debian Bullseye definition.
* Drop Debian Stretch definition.
* Add Ubuntu Jammy definition.
* Drop Ubuntu Xenial definition.
@nuclearsandwich
Temporarily redefine keys for xenial.
77db9cc 
#31569
@nuclearsandwich
Copy link
Member Author

Same comment here about removing the xenial keys; I think we agreed to keep them for now.

Re xenial: We talked about it in #31569 and have guidance for how to use older tags. I'd suggest that we go ahead and remove them.

I've added a commit which temporarily restores the Xenial definitions to be removed once the Xenial discussion issue closes.

@nuclearsandwich nuclearsandwich merged commit 63d31db into master Jan 6, 2022
@nuclearsandwich nuclearsandwich deleted the nuclearsandwich/boost branch January 6, 2022 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette left review comments

@tfoote tfoote tfoote approved these changes

Assignees

@nuclearsandwich nuclearsandwich

Labels
rosdep Issue/PR is for a rosdep key
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nuclearsandwich @clalancette @tfoote