[Humble] Fixing 4230 #4272
Merged
[Humble] Fixing 4230 #4272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Macenski <[email protected]>
|
Does the fix have any impact on behavior? Cannot identify any |
RBT22
pushed a commit
to EnjoyRobotics/navigation2
that referenced
this pull request
May 9, 2024
Signed-off-by: Steve Macenski <[email protected]>
RBT22
added a commit
to EnjoyRobotics/navigation2
that referenced
this pull request
May 9, 2024
[Humble] Fixing 4230 (ros-navigation#4272)
|
Yes, it restarts to iterate from the start of each trajectory in the batch. Before it started at the furthest from the last sample which is bad since each trajectory candidate should be scored independently and fully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.