Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Removed additional sign multiplication in RPP angular velocity (in backward motion) #3088

Merged
merged 1 commit into from
Aug 19, 2022
Merged

fix: Removed additional sign multiplication in RPP angular velocity (in backward motion) #3088

merged 1 commit into from
Aug 19, 2022

Conversation

automech-rb
Copy link
Contributor

Basic Info

Info Please fill out this column
Ticket(s) this addresses #3086
Primary OS tested on Docker 20.04 Ubuntu
Robotic platform tested on Ignition differential sim

Description of contribution in a few bullet points

Removed the additional sign* bug from this PR.

Description of documentation updates required from your changes

None

Future work that may be required in bullet points

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@mergify
Copy link
Contributor

mergify bot commented Jul 23, 2022

@automech-rb, please properly fill in PR template in the future. @SteveMacenski, use this instead.

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@automech-rb automech-rb changed the title fix: Removed additional sign multiplication in RPP angular velocity (backward motion) fix: Removed additional sign multiplication in RPP angular velocity (in backward motion) Jul 23, 2022
@SteveMacenski SteveMacenski merged commit ef76b5b into ros-navigation:main Aug 19, 2022
@mergify mergify bot mentioned this pull request Aug 19, 2022
Merged
mergify bot pushed a commit that referenced this pull request Aug 19, 2022
@automech-rb @mergify
Removed additional sign multiplication (#3088)
6e31d48 
(cherry picked from commit ef76b5b)
@mergify mergify bot mentioned this pull request Aug 19, 2022
Merged
mergify bot pushed a commit that referenced this pull request Aug 19, 2022
@automech-rb @mergify
Removed additional sign multiplication (#3088)
81fd697 
(cherry picked from commit ef76b5b)
SteveMacenski pushed a commit that referenced this pull request Aug 19, 2022
@mergify @automech-rb
Removed additional sign multiplication (#3088) (#3125)
10cd1a1 
(cherry picked from commit ef76b5b)

Co-authored-by: autome <[email protected]>
SteveMacenski pushed a commit that referenced this pull request Aug 19, 2022
@mergify @automech-rb
Removed additional sign multiplication (#3088) (#3126)
3df00a7 
(cherry picked from commit ef76b5b)

Co-authored-by: autome <[email protected]>
jwallace42 pushed a commit to jwallace42/navigation2 that referenced this pull request Aug 22, 2022
@automech-rb @jwallace42
Removed additional sign multiplication (ros-navigation#3088)
8b6537b
hodgespodge pushed a commit to RobotCodeLab/navigation2 that referenced this pull request Sep 12, 2022
@mergify @automech-rb @hodgespodge
Removed additional sign multiplication (ros-navigation#3088) (ros-nav…
0aa7342 
…igation#3126)

(cherry picked from commit ef76b5b)

Co-authored-by: autome <[email protected]>
jwallace42 pushed a commit to jwallace42/navigation2 that referenced this pull request Dec 14, 2022
@automech-rb
Removed additional sign multiplication (ros-navigation#3088)
e1830c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMacenski SteveMacenski SteveMacenski approved these changes

Assignees
No one assigned
Labels
backport-galactic backport-humble
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@automech-rb @SteveMacenski