-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for Windows #2595
Fixes for Windows #2595
Conversation
Replace sleep with Sleep on Windows
Undef NO_ERROR from windows headers
* Define _USE_MATH_DEFINES for M_PI * Replace uint with unsigned int * Don't add compiler flags that aren't supported on MSVC * Use vector instead of VLA when building with MSVC
All new development needs to be targeted to |
I also question if this PR builds if |
This branch should build. I have been using it for a while now. I have a successful CI build using my branch from a week ago here |
Basic Info
Description of contribution in a few bullet points
Description of documentation updates required from your changes
N/A
Future work that may be required in bullet points
None, Nav2 seems to work completely on Windows
For Maintainers: