Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing export of pluginlib boost disable flag #2432

Conversation

devrite
Copy link
Contributor

@devrite devrite commented Jul 2, 2021


Basic Info

Info Please fill out this column
Ticket(s) this addresses #2429
Primary OS tested on Ubuntu
Robotic platform tested on none

Description of contribution in a few bullet points

  • Used ament_export_definitions
  • Veridied flag being applied by nav2_costmap_2d to gridmap_costmap_2d in foxy

Description of documentation updates required from your changes

None required. Should be transparent to the user.


Future work that may be required in bullet points

None. Rolling and galactic can just remove the flags (see #2431).

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@SteveMacenski SteveMacenski merged commit 1065083 into ros-navigation:foxy-devel Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants