-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kinematic parameters test #2031
Merged
SteveMacenski
merged 2 commits into
ros-navigation:main
from
wilcobonestroo:add-kinematic-parameters-test
Oct 12, 2020
Merged
Add kinematic parameters test #2031
SteveMacenski
merged 2 commits into
ros-navigation:main
from
wilcobonestroo:add-kinematic-parameters-test
Oct 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveMacenski
approved these changes
Oct 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, no changes. CI is failing, I'll try to look into it. Given this is small, if you can build it locally, I'll just merge this one.
It builds fine locally. |
SteveMacenski
added a commit
that referenced
this pull request
Oct 13, 2020
…tor (#2032) * Added a test with controller_frequency of 0. The controller should get a default frequency of 20. * Add kinematic parameters test (#2031) * Add kinematic parameters tests. * Solve uncrustify error. * [WIP fixing CI] changing gazebo base to my fork for testing (#2034) * changing gazebo base to my fork for testing * adding buffer header per TF2 API changes * moving header to header * Adding additional SmacPlanner tests (#2036) * adding some more tests to smac_planner * addtl smac tests * remove unused functions * adding additional constants and smoothers tests (#2038) * Added tests for different controller frequencies. * Added a test with controller_frequency of 0. The controller should get a default frequency of 20. * Added tests for different controller frequencies. * Solve uncrustify issue. Co-authored-by: Steve Macenski <[email protected]>
ruffsl
pushed a commit
to ruffsl/navigation2
that referenced
this pull request
Jul 2, 2021
* Add kinematic parameters tests. * Solve uncrustify error.
ruffsl
pushed a commit
to ruffsl/navigation2
that referenced
this pull request
Jul 2, 2021
…tor (ros-navigation#2032) * Added a test with controller_frequency of 0. The controller should get a default frequency of 20. * Add kinematic parameters test (ros-navigation#2031) * Add kinematic parameters tests. * Solve uncrustify error. * [WIP fixing CI] changing gazebo base to my fork for testing (ros-navigation#2034) * changing gazebo base to my fork for testing * adding buffer header per TF2 API changes * moving header to header * Adding additional SmacPlanner tests (ros-navigation#2036) * adding some more tests to smac_planner * addtl smac tests * remove unused functions * adding additional constants and smoothers tests (ros-navigation#2038) * Added tests for different controller frequencies. * Added a test with controller_frequency of 0. The controller should get a default frequency of 20. * Added tests for different controller frequencies. * Solve uncrustify issue. Co-authored-by: Steve Macenski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points