Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kinematic parameters test #2031

Merged
merged 2 commits into from
Oct 12, 2020
Merged

Add kinematic parameters test #2031

merged 2 commits into from
Oct 12, 2020

Conversation

wilcobonestroo
Copy link
Contributor

Basic Info

Info Please fill out this column
Primary OS tested on Ubuntu

Description of contribution in a few bullet points

  • I added a test for settting the kinematic parameters in nav2_dwb_controller / dwb_plugins.

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no changes. CI is failing, I'll try to look into it. Given this is small, if you can build it locally, I'll just merge this one.

@wilcobonestroo
Copy link
Contributor Author

It builds fine locally.

@SteveMacenski SteveMacenski merged commit be38a7a into ros-navigation:main Oct 12, 2020
@wilcobonestroo wilcobonestroo deleted the add-kinematic-parameters-test branch October 13, 2020 10:39
SteveMacenski added a commit that referenced this pull request Oct 13, 2020
…tor (#2032)

* Added a test with controller_frequency of 0. The controller should get a default frequency of 20.

* Add kinematic parameters test (#2031)

* Add kinematic parameters tests.

* Solve uncrustify error.

* [WIP fixing CI] changing gazebo base to my fork for testing (#2034)

* changing gazebo base to my fork for testing

* adding buffer header per TF2 API changes

* moving header to header

* Adding additional SmacPlanner tests (#2036)

* adding some more tests to smac_planner

* addtl smac tests

* remove unused functions

* adding additional constants and smoothers tests (#2038)

* Added tests for different controller frequencies.

* Added a test with controller_frequency of 0. The controller should get a default frequency of 20.

* Added tests for different controller frequencies.

* Solve uncrustify issue.

Co-authored-by: Steve Macenski <[email protected]>
ruffsl pushed a commit to ruffsl/navigation2 that referenced this pull request Jul 2, 2021
* Add kinematic parameters tests.

* Solve uncrustify error.
ruffsl pushed a commit to ruffsl/navigation2 that referenced this pull request Jul 2, 2021
…tor (ros-navigation#2032)

* Added a test with controller_frequency of 0. The controller should get a default frequency of 20.

* Add kinematic parameters test (ros-navigation#2031)

* Add kinematic parameters tests.

* Solve uncrustify error.

* [WIP fixing CI] changing gazebo base to my fork for testing (ros-navigation#2034)

* changing gazebo base to my fork for testing

* adding buffer header per TF2 API changes

* moving header to header

* Adding additional SmacPlanner tests (ros-navigation#2036)

* adding some more tests to smac_planner

* addtl smac tests

* remove unused functions

* adding additional constants and smoothers tests (ros-navigation#2038)

* Added tests for different controller frequencies.

* Added a test with controller_frequency of 0. The controller should get a default frequency of 20.

* Added tests for different controller frequencies.

* Solve uncrustify issue.

Co-authored-by: Steve Macenski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants