Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add amcl's service request to robot class #427

Closed
mhpanah opened this issue Dec 5, 2018 · 3 comments
Closed

[WIP] Add amcl's service request to robot class #427

mhpanah opened this issue Dec 5, 2018 · 3 comments
Assignees
@mhpanah
Labels
2 - Medium Medium Priority enhancement New feature or request
Milestone
D Turtle Release

Comments

@mhpanah
Copy link
Contributor

mhpanah commented Dec 5, 2018

Feature request

Feature description

Add global localization and no motion update service request to robot class. This is the first step to create robot's selfLocalization method.
@mhpanah mhpanah self-assigned this Dec 5, 2018
@mkhansenbot
Copy link
Collaborator

Can you explain a little better what this means? Why does the robot need a self.localization method?

@mkhansenbot mkhansenbot added the enhancement New feature or request label Dec 7, 2018
@mkhansenbot mkhansenbot added the 2 - Medium Medium Priority label Dec 7, 2018
@mkhansenbot
Copy link
Collaborator

Labeling this medium priority for now but not clear to me what this will really do differently than what we have today.

@mkhansenbot mkhansenbot added this to the D Turtle Release milestone Dec 10, 2018
@mhpanah
Copy link
Contributor Author

mhpanah commented Jan 3, 2019

Addressed in #503 #504.

@mhpanah mhpanah closed this as completed Jan 3, 2019
tonynajjar pushed a commit to logivations/navigation2 that referenced this issue Nov 3, 2022
Btpanel (ros-navigation#427)
8b6ef7b 
* compatibility

* add UID
mini-1235 pushed a commit to mini-1235/navigation2 that referenced this issue Feb 5, 2025
@OTL
Fix parameter name for params_file (ros-navigation#427)
341cc01 
The parameter name for parameter file has a typo.
It's actually `param*s*_file`.

https://github.com/ros-planning/navigation2/blob/1b5920cc253e33a14cd94c81cccf670d13ee13cf/nav2_bringup/launch/bringup_launch.py#L41
Forsyth-Creations pushed a commit to Forsyth-Creations/navigation2 that referenced this issue Feb 19, 2025
Use a "steady clock" when measuring time differences (ros-navigation#427
fe89a54 
)

* Use "steady" clocks when measuring changes in time
* Check if the "publish rate" tests pass now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhpanah mhpanah

Labels
2 - Medium Medium Priority enhancement New feature or request
Projects
None yet
Milestone
D Turtle Release
Development

No branches or pull requests
2 participants
@mkhansenbot @mhpanah