Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update maintainers and add url tags #1363

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Update maintainers and add url tags #1363

merged 2 commits into from
Nov 12, 2024

Conversation

christophfroehlich
Copy link
Contributor

The contents of the package.xml get parsed for index.ros.org, so I thought it might be worth updating them.

  • Update the current maintainers
  • Where possible, I added the original authors as <author>
  • add url tags, but only to github and control.ros.org homepage. The direct links to the controllers have the ROS distro in the URL, that would soon become outdated.

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. backport-iron labels Nov 11, 2024
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor changes

diff_drive_controller/package.xml Outdated Show resolved Hide resolved
diff_drive_controller/package.xml Show resolved Hide resolved
Co-authored-by: Sai Kishor Kothakota <[email protected]>
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.87%. Comparing base (f519170) to head (8b1e67c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1363      +/-   ##
==========================================
- Coverage   80.89%   80.87%   -0.03%     
==========================================
  Files         109      109              
  Lines        9696     9699       +3     
  Branches      842      845       +3     
==========================================
  Hits         7844     7844              
  Misses       1574     1574              
- Partials      278      281       +3     
Flag Coverage Δ
unittests 80.87% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and I checked that

$ xmllint --noout --schema http://download.ros.org/schema/package_format3.xsd */package.xml
ackermann_steering_controller/package.xml validates
admittance_controller/package.xml validates
bicycle_steering_controller/package.xml validates
diff_drive_controller/package.xml validates
effort_controllers/package.xml validates
force_torque_sensor_broadcaster/package.xml validates
forward_command_controller/package.xml validates
gripper_controllers/package.xml validates
imu_sensor_broadcaster/package.xml validates
joint_state_broadcaster/package.xml validates
joint_trajectory_controller/package.xml validates
parallel_gripper_controller/package.xml validates
pid_controller/package.xml validates
pose_broadcaster/package.xml validates
position_controllers/package.xml validates
range_sensor_broadcaster/package.xml validates
ros2_controllers/package.xml validates
ros2_controllers_test_nodes/package.xml validates
rqt_joint_trajectory_controller/package.xml validates
steering_controllers_library/package.xml validates
tricycle_controller/package.xml validates
tricycle_steering_controller/package.xml validates
velocity_controllers/package.xml validates

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@bmagyar bmagyar merged commit de77fd0 into master Nov 12, 2024
18 of 20 checks passed
@bmagyar bmagyar deleted the fix/package-xml branch November 12, 2024 15:48
mergify bot pushed a commit that referenced this pull request Nov 12, 2024
(cherry picked from commit de77fd0)

# Conflicts:
#	ackermann_steering_controller/package.xml
#	bicycle_steering_controller/package.xml
#	diff_drive_controller/package.xml
#	parallel_gripper_controller/package.xml
#	range_sensor_broadcaster/package.xml
#	ros2_controllers/package.xml
#	steering_controllers_library/package.xml
#	tricycle_steering_controller/package.xml
mergify bot pushed a commit that referenced this pull request Nov 12, 2024
(cherry picked from commit de77fd0)

# Conflicts:
#	diff_drive_controller/package.xml
#	parallel_gripper_controller/package.xml
#	pose_broadcaster/package.xml
#	range_sensor_broadcaster/package.xml
#	ros2_controllers/package.xml
christophfroehlich added a commit that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants