-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update maintainers and add url tags #1363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor changes
Co-authored-by: Sai Kishor Kothakota <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1363 +/- ##
==========================================
- Coverage 80.89% 80.87% -0.03%
==========================================
Files 109 109
Lines 9696 9699 +3
Branches 842 845 +3
==========================================
Hits 7844 7844
Misses 1574 1574
- Partials 278 281 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and I checked that
$ xmllint --noout --schema http://download.ros.org/schema/package_format3.xsd */package.xml
ackermann_steering_controller/package.xml validates
admittance_controller/package.xml validates
bicycle_steering_controller/package.xml validates
diff_drive_controller/package.xml validates
effort_controllers/package.xml validates
force_torque_sensor_broadcaster/package.xml validates
forward_command_controller/package.xml validates
gripper_controllers/package.xml validates
imu_sensor_broadcaster/package.xml validates
joint_state_broadcaster/package.xml validates
joint_trajectory_controller/package.xml validates
parallel_gripper_controller/package.xml validates
pid_controller/package.xml validates
pose_broadcaster/package.xml validates
position_controllers/package.xml validates
range_sensor_broadcaster/package.xml validates
ros2_controllers/package.xml validates
ros2_controllers_test_nodes/package.xml validates
rqt_joint_trajectory_controller/package.xml validates
steering_controllers_library/package.xml validates
tricycle_controller/package.xml validates
tricycle_steering_controller/package.xml validates
velocity_controllers/package.xml validates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
(cherry picked from commit de77fd0) # Conflicts: # ackermann_steering_controller/package.xml # bicycle_steering_controller/package.xml # diff_drive_controller/package.xml # parallel_gripper_controller/package.xml # range_sensor_broadcaster/package.xml # ros2_controllers/package.xml # steering_controllers_library/package.xml # tricycle_steering_controller/package.xml
(cherry picked from commit de77fd0) # Conflicts: # diff_drive_controller/package.xml # parallel_gripper_controller/package.xml # pose_broadcaster/package.xml # range_sensor_broadcaster/package.xml # ros2_controllers/package.xml
Co-authored-by: Christoph Fröhlich <[email protected]>
The contents of the package.xml get parsed for index.ros.org, so I thought it might be worth updating them.
<author>