-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acorn 2.x (Laravel 8.x) #74
Conversation
Is the project still alive? |
yes? all roots team members have full-time commitments outside of our open-source projects this PR isn't even that old. but thanks for the motivation! 😄 |
I'm sorry if I sounded mean. We use Sage 10, which heavily based on Acorn. The idea, project and everything are just great. We have almost finished one bigger project and we love it. We really want to make it our company standard and I hope in the longer term be able to contribute to the community :-) |
Hi, I checked out this PR with an (nearly) fresh
$dotenv = Dotenv\Dotenv::createImmutable($root_dir); to $dotenv = Dotenv\Dotenv::createUnsafeImmutable($root_dir);
|
Hey @sagalbot, yeah, I was requiring the |
* feat(deps): Update to Laravel 8.x * fix(container): Properly configure path bindings on container (Fixes #82, Supersedes #83) * refactor(acorn): Add required bindings from `Illuminate\Foundation` to codebase * refactor(acorn): Remove hardcoded Foundation logic from Acorn's codebase * refactor(acorn): Reimplement various classes to properly extend Foundation bindings as-needed * feat(acorn): Add lazy-loading support for services * enhance(exceptions): Improve Whoops/Exceptions implementation * enhance(console): Improve WP_CLI implementation * chore(console): Remove unnecessary console helper traits
This is a fairly significant restructuring of things.
I haven't extensively tested everything, but I did make sure a sage 10 site loads without any errors and the wp-cli commands are working.
Tests are going to be failing because they need to be refactored. I can handle that this weekend.
(I'll document all of the changes I made later.)