Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acorn 2.x (Laravel 8.x) #74

Merged
merged 9 commits into from
Feb 3, 2021
Merged

Acorn 2.x (Laravel 8.x) #74

merged 9 commits into from
Feb 3, 2021

Conversation

QWp6t
Copy link
Member

@QWp6t QWp6t commented Sep 29, 2020

This is a fairly significant restructuring of things.

I haven't extensively tested everything, but I did make sure a sage 10 site loads without any errors and the wp-cli commands are working.

Tests are going to be failing because they need to be refactored. I can handle that this weekend.

(I'll document all of the changes I made later.)

@kmiskiewicz
Copy link

Is the project still alive?

@retlehs
Copy link
Member

retlehs commented Nov 13, 2020

yes? all roots team members have full-time commitments outside of our open-source projects

this PR isn't even that old. but thanks for the motivation! 😄

@kmiskiewicz
Copy link

I'm sorry if I sounded mean. We use Sage 10, which heavily based on Acorn. The idea, project and everything are just great. We have almost finished one bigger project and we love it. We really want to make it our company standard and I hope in the longer term be able to contribute to the community :-)
Thank you for a great project!

@dsturm
Copy link
Contributor

dsturm commented Nov 26, 2020

Hi,

I checked out this PR with an (nearly) fresh roots/sage theme and ran into two problems:

  1. As I'm using a roots/bedrock project, requiring this branch / PR resulted in an conflict with the vlucas/phpdotenv package in Roots\Acorn\Bootstrap\LoadConfiguration::bootstrap: roots/bedrock currently requires ^4.1.8, while Laravel 8.x uses ^5.2. While I'm not sure, why not to require vlucas/phpdotenv on package base, installing it in the theme directory would load the bedrock version though. So, to fix it I had to upgrade bedrock to ^5.2. This required a migration change on config/application.php:
$dotenv = Dotenv\Dotenv::createImmutable($root_dir);

to

$dotenv = Dotenv\Dotenv::createUnsafeImmutable($root_dir);
  1. Next I got an exception The ~/sites/bedrock/web/app/themes/sage/storage/bootstrap/cache directory must be present and writable.. After creating the directory, everything worked fine.

@sagalbot
Copy link

@dsturm did you end up shipping the project using this fork?

@retlehs as this is a pretty significant PR, is there a way to break it up into manageable, reviewable chunks? @QWp6t do you recall what tasks remain to implement this outside of refactoring tests?

@dsturm
Copy link
Contributor

dsturm commented Jan 12, 2021

Hey @sagalbot, yeah, I was requiring the laravel8 branch and the - now - merged roots/bedrock#563 with no problems.

@Log1x Log1x mentioned this pull request Jan 14, 2021
Log1x and others added 7 commits February 2, 2021 22:20
* feat(deps): Update to Laravel 8.x
* fix(container): Properly configure path bindings on container (Fixes #82, Supersedes #83)
* refactor(acorn): Add required bindings from `Illuminate\Foundation` to codebase
* refactor(acorn): Remove hardcoded Foundation logic from Acorn's codebase
* refactor(acorn): Reimplement various classes to properly extend Foundation bindings as-needed
* feat(acorn): Add lazy-loading support for services
* enhance(exceptions): Improve Whoops/Exceptions implementation
* enhance(console): Improve WP_CLI implementation
* chore(console): Remove unnecessary console helper traits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants