Upgrade to vlucas/phpdotenv:5.2

[dsturm]

This PR upgrades vlucas/phpdotenv to the current version of 5.2. As in roots/acorn#74 (comment) mentioned, Laravel 8.x and therefor roots/acorn with support for Laravel 8.x will need an upgrade of the package and minor migration changes.

[tangrufus]

Question: Any reason to support v4?
If not for any important dependency conflicts, we can ditch the Dotenv\Dotenv::createImmutable condition.

[dsturm]

Question: Any reason to support v4?
If not for any important dependency conflicts, we can ditch the Dotenv\Dotenv::createImmutable condition.

To be honest, I don't know if we really need v4. Since v5 only increase the PHP version to 7.1 and above I would say, we could ditch v4.

[tangrufus]

we could ditch v4.

Please.

[retlehs]

thank you!

[trainoasis]

How do I manually update to phpdotenv v5 from v3 without destroying everything? :D need it sorely for composer package requirements 🗡️

[LucasDemea]

Is there any particular reason for using

Dotenv\Dotenv::createUnsafeImmutable($root_dir, $env_files, false);

Instead of using

Dotenv\Dotenv::createImmutable($root_dir, $env_files, false);

and changing all the env('CONST') to $_ENV['CONST'] ?

It is discouraged to use createUnsafeImmutable , as stated on phpdotenv page :

Using getenv() and putenv() is strongly discouraged due to the fact that these functions are not thread safe, however it is still possible to instruct PHP dotenv to use these functions. Instead of calling Dotenv::createImmutable, one can call Dotenv::createUnsafeImmutable, which will add the PutenvAdapter behind the scenes.

I also encoutered an issue while trying to setup an automated test environment with wp-browser and the WPLoader module. env('CONST') wasn't returning anything, but $_ENV('CONST') did.

[swalkinshaw]

@LucasDemea I think this PR is what you're suggesting? #598

Just need to re-verify it and merge

[LucasDemea]

Kind of, but I just tested you implementation and it doesnt solve my issue where env('CONST') doesn't return anything when wordpress is loaded by WPLoader.

[LucasDemea]

I'm aware that this is more an issue related to wp-browser. I will pursue my investigation this way.