Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind paths in container #83

Closed

Conversation

stefanfisk
Copy link
Contributor

Fixes #82.

@Log1x Log1x mentioned this pull request Jan 14, 2021
Log1x added a commit that referenced this pull request Feb 3, 2021
* feat(deps): Update to Laravel 8.x
* fix(container): Properly configure path bindings on container (Fixes #82, Supersedes #83)
* refactor(acorn): Add required bindings from `Illuminate\Foundation` to codebase
* refactor(acorn): Remove hardcoded Foundation logic from Acorn's codebase
* refactor(acorn): Reimplement various classes to properly extend Foundation bindings as-needed
* feat(acorn): Add lazy-loading support for services
* enhance(exceptions): Improve Whoops/Exceptions implementation
* enhance(console): Improve WP_CLI implementation
* chore(console): Remove unnecessary console helper traits
Base automatically changed from master to main February 4, 2021 19:34
@QWp6t
Copy link
Member

QWp6t commented Feb 4, 2021

Thanks for the PR. 👍

This change has been implemented in the main branch as part of our Acorn 2.x updates (#74).

We will tag a release sometime soon.

@QWp6t QWp6t closed this Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

public_path() breaks because paths are not bound
2 participants