[Minuit2] Revert recent changes to virtual function signature #16491
Conversation
This reverts part of 63636f6 from a few days ago, which also changed the interface of virtual functions, which was not the intention and breaks user code.
|
@smuzaffar, FYI. Sorry for accidentally breaking the code! My other PR was done with find and replace, and I didn't consider this case of virtual functions where changing the signature actually breaks user code! I will also open a PR to CMSSW to make things right. Because there is indeed also a PR with breaking changes that were intended and that will further break cmssw: #16443 Other than that PR, no breaking changes are planned for Minuit2. |
Test Results 13 files 13 suites 3d 1h 38m 25s ⏱️ Results for commit d9b0461. ♻️ This comment has been updated with latest results. |
|
@smuzaffar, @iarspider, would now be a good moment to merge this? If not, please let me know when. Thanks! |
|
yes , it can go in. I will any way test it with your cmssw PR cms-sw/cmssw#46079 now |
|
Ok, thanks! |
This reverts part of 63636f6 from a few days ago, which also changed the interface of virtual functions, which was not the intention and breaks user code.