Follow up on recent Minuit 2 code changes #46079

guitargeek · 2024-09-20T18:24:50Z

See this comment for more context.

This PR will work with ROOT <=6.32 or with ROOT master once this PR is merged:
root-project/root#16491

@smuzaffar, FYI, sorry again for the trouble!

cmsbuild · 2024-09-20T18:25:17Z

cms-bot internal usage

cmsbuild · 2024-09-20T18:30:21Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46079/41868

cmsbuild · 2024-09-20T18:30:40Z

A new Pull Request was created by @guitargeek for master.

It involves the following packages:

OnlineDB/CSCCondDB (db)
RecoVertex/BeamSpotProducer (alca, reconstruction)

@atpathak, @cmsbuild, @consuegs, @francescobrivio, @jfernan2, @mandrenguyen, @perrotta can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanChyczynski, @JanFSchulte, @PonIlya, @VinInn, @VourMa, @dgulhan, @fabiocos, @francescobrivio, @martinamalberti, @missirol, @mmusich, @mtosi, @rovere, @rsreds, @tocheng, @yuanchao this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2024-09-23T06:35:37Z

please test

cmsbuild · 2024-09-23T06:38:37Z

Pull request has been put on hold by @smuzaffar
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

cmsbuild · 2024-09-23T06:51:18Z

-1

Failed Tests: Build ClangBuild
Size: This PR adds an extra 12KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3cf109/41693/summary.html
COMMIT: 325c9e3
CMSSW: CMSSW_14_2_X_2024-09-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46079/41693/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling  src/OnlineDB/CSCCondDB/src/CSCMap1.cc
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH='CMSSW_14_2_X_2024-09-22-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_14_2_X_2024-09-22-2300' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-09-22-2300/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/pcre/8.43-e34796d17981e9b6d174328c69446455/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/boost/1.80.0-7ac88d918a6883d593abc133ee0eb2e9/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/clhep/2.4.7.1-17c7283747b6cbc68a3534cb987a890c/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/gsl/2.6-4e597de26ced42091883404fa44cef2e/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/oracle/19.11.0.0.0dbru-0ef9ee763c1e7a90d8c4515a5af97f0b/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/lcg/root/6.30.09-3554debf6c24028c1aba0a9621fdb6c2/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/tbb/v2021.9.0-2391c941213c757dc9a1835b31681235/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/zlib/1.2.11-1a082fc322b0051b504cc023f21df178/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-39786ff94f8aa2f543922cad720e1b32/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-39786ff94f8aa2f543922cad720e1b32/include/eigen3 -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/fmt/10.2.1-deba157dd76fed17ac8b42adc60ff53f/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/OpenBLAS/0.3.27-6574458f8642b299ac965c654e194a8b/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/tinyxml2/6.2.0-68d511689c5dbd9a0d296bbb795fa052/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v2 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc12/src/OnlineDB/CSCCondDB/src/OnlineDBCSCCondDB/CSCMap1.cc.d src/OnlineDB/CSCCondDB/src/CSCMap1.cc -o tmp/el8_amd64_gcc12/src/OnlineDB/CSCCondDB/src/OnlineDBCSCCondDB/CSCMap1.cc.o
>> Compiling  src/OnlineDB/CSCCondDB/src/CSCOnlineDB.cc
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/bin/c++ -c -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=120301 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DCMSSW_GIT_HASH='CMSSW_14_2_X_2024-09-22-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_14_2_X_2024-09-22-2300' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_14_2_X_2024-09-22-2300/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/pcre/8.43-e34796d17981e9b6d174328c69446455/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/boost/1.80.0-7ac88d918a6883d593abc133ee0eb2e9/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/bz2lib/1.0.6-d065ccd79984efc6d4660f410e4c81de/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/clhep/2.4.7.1-17c7283747b6cbc68a3534cb987a890c/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/gsl/2.6-4e597de26ced42091883404fa44cef2e/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/libuuid/2.34-27ce4c3579b5b1de2808ea9c4cd8ed29/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/oracle/19.11.0.0.0dbru-0ef9ee763c1e7a90d8c4515a5af97f0b/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/lcg/root/6.30.09-3554debf6c24028c1aba0a9621fdb6c2/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/tbb/v2021.9.0-2391c941213c757dc9a1835b31681235/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/xz/5.2.5-6f3f49b07db84e10c9be594a1176c114/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/zlib/1.2.11-1a082fc322b0051b504cc023f21df178/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-39786ff94f8aa2f543922cad720e1b32/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/eigen/3bb6a48d8c171cf20b5f8e48bfb4e424fbd4f79e-39786ff94f8aa2f543922cad720e1b32/include/eigen3 -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/fmt/10.2.1-deba157dd76fed17ac8b42adc60ff53f/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/md5/1.0.0-5b594b264e04ae51e893b1d69a797ec6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/OpenBLAS/0.3.27-6574458f8642b299ac965c654e194a8b/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/external/tinyxml2/6.2.0-68d511689c5dbd9a0d296bbb795fa052/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v2 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el8_amd64_gcc12/src/OnlineDB/CSCCondDB/src/OnlineDBCSCCondDB/CSCOnlineDB.cc.d src/OnlineDB/CSCCondDB/src/CSCOnlineDB.cc -o tmp/el8_amd64_gcc12/src/OnlineDB/CSCCondDB/src/OnlineDBCSCCondDB/CSCOnlineDB.cc.o
src/OnlineDB/CSCCondDB/src/CSCFitAFEBThr.cc: In member function 'virtual bool CSCFitAFEBThr::ThresholdNoise(const std::vector&, const std::vector&, const int&, std::vector&, std::vector&, std::vector&, float&, float&, int&, int&, float&) const':
src/OnlineDB/CSCCondDB/src/CSCFitAFEBThr.cc:132:92: error: invalid use of incomplete type 'class ROOT::Minuit2::MnStrategy'
  132 |   FunctionMinimum fmin = theFitter->Minimize(*theOBJfun, {parinit, erparinit}, MnStrategy{1}, 500, 0.1);
      |                                                                                            ^
In file included from /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/lcg/root/6.30.09-3554debf6c24028c1aba0a9621fdb6c2/include/Minuit2/VariableMetricMinimizer.h:14,
                 from src/OnlineDB/CSCCondDB/interface/CSCFitAFEBThr.h:11,
                 from src/OnlineDB/CSCCondDB/src/CSCFitAFEBThr.cc:3:

Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Local Products Rules ..... done
>> Creating project symlinks
>> Entering Package OnlineDB/CSCCondDB
>> Entering Package RecoVertex/BeamSpotProducer
>> Compile sequence completed for CMSSW CMSSW_14_2_X_2024-09-22-2300
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_2_X_2024-09-22-2300/tmp/el8_amd64_gcc12/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package OnlineDB/CSCCondDB
Entering library rule at src/OnlineDB/CSCCondDB/plugins
>> Compiling edm plugin src/OnlineDB/CSCCondDB/plugins/CSCMap1Read.cc

smuzaffar · 2024-09-23T08:46:40Z

OnlineDB/CSCCondDB/src/CSCFitAFEBThr.cc

-#else
-  FunctionMinimum fmin = theFitter->Minimize(*theOBJfun, parinit, erparinit, 1, 500, 0.1);
-#endif
+  FunctionMinimum fmin = theFitter->Minimize(*theOBJfun, {parinit, erparinit}, MnStrategy{1}, 500, 0.1);


@guitargeek , looks like this change does not work for root 6.30 (#46079 (comment) )

src/OnlineDB/CSCCondDB/src/CSCFitAFEBThr.cc: In member function 'virtual bool CSCFitAFEBThr::ThresholdNoise(const std::vector&, const std::vector&, const int&, std::vector&, std::vector&, std::vector&, float&, float&, int&, int&, float&) const': src/OnlineDB/CSCCondDB/src/CSCFitAFEBThr.cc:132:92: error: invalid use of incomplete type 'class ROOT::Minuit2::MnStrategy' 132 | FunctionMinimum fmin = theFitter->Minimize(*theOBJfun, {parinit, erparinit}, MnStrategy{1}, 500, 0.1); | ^ In file included from /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02856/el8_amd64_gcc12/lcg/root/6.30.09-3554debf6c24028c1aba0a9621fdb6c2/include/Minuit2/VariableMetricMinimizer.h:14, from src/OnlineDB/CSCCondDB/interface/CSCFitAFEBThr.h:11, from src/OnlineDB/CSCCondDB/src/CSCFitAFEBThr.cc:3:

@smuzaffar @guitargeek adding #include <Minuit2/MnStrategy.h> may help.

Good catch! I'll add this.

It was already added by another PR now (thanks!):
#46195

guitargeek · 2024-10-06T11:50:05Z

Alright, there was some problem with the overload resolution in case of ROOT 6.30. I now construct the MnUserParameterState explicitly, then it should work with all ROOT versions. I tested it with the most recent IB: CMSSW_14_2_X_2024-10-06-0000.

cmsbuild · 2024-10-06T11:51:00Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46079/42099

cmsbuild · 2024-10-06T11:51:24Z

Pull request #46079 was updated. @atpathak, @cmsbuild, @consuegs, @francescobrivio, @jfernan2, @mandrenguyen, @perrotta can you please check and sign again.

smuzaffar · 2024-10-06T12:57:13Z

Please test

cmsbuild · 2024-10-06T16:26:35Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3cf109/42001/summary.html
COMMIT: 43574ba
CMSSW: CMSSW_14_2_X_2024-10-06-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/46079/42001/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 6 lines from the logs
Reco comparison results: 26 differences found in the comparisons
DQMHistoTests: Total files compared: 45
DQMHistoTests: Total histograms compared: 3438002
DQMHistoTests: Total failures: 1430
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3436552
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
Checked 197 log files, 168 edm output root files, 45 DQM output files
TriggerResults: no differences found

jfernan2 · 2024-10-07T14:05:29Z

+1

smuzaffar · 2024-10-10T06:32:27Z

@cms-sw/alca-l2 @cms-sw/db-l2 can you please review this? This is revert of #45965 PR . This is needed to integrate latest root 6.33/master changes in to our ROOT6_X IBs

perrotta · 2024-10-10T07:35:49Z

+1

cmsbuild · 2024-10-10T09:03:42Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2024-10-10T09:04:31Z

+1

cmsbuild added this to the CMSSW_14_2_X milestone Sep 20, 2024

cmsbuild added reconstruction-pending alca-pending db-pending pending-signatures tests-pending orp-pending code-checks-pending tracking labels Sep 20, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 20, 2024

cmsbuild added tests-started and removed tests-pending labels Sep 23, 2024

cmsbuild added the hold label Sep 23, 2024

cmsbuild added tests-rejected and removed tests-started labels Sep 23, 2024

smuzaffar reviewed Sep 23, 2024

View reviewed changes

iarspider mentioned this pull request Oct 1, 2024

[ROOTMaster] Updated root to tip of branch master cms-sw/cmsdist#9441

Merged

cmsbuild mentioned this pull request Oct 2, 2024

Fixes after root-project/root#16443 #46195

Merged

guitargeek force-pushed the minuit2_fix branch from 325c9e3 to 19e3538 Compare October 3, 2024 11:51

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Oct 3, 2024

cmsbuild added tests-pending code-checks-pending labels Oct 6, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 6, 2024

cmsbuild added tests-started and removed tests-pending labels Oct 6, 2024

cmsbuild added tests-approved and removed tests-started labels Oct 6, 2024

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Oct 7, 2024

cmsbuild added alca-approved db-approved fully-signed and removed alca-pending db-pending pending-signatures hold labels Oct 10, 2024

cmsbuild added orp-approved and removed orp-pending labels Oct 10, 2024

cmsbuild merged commit ea0fd48 into cms-sw:master Oct 10, 2024
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Follow up on recent Minuit 2 code changes #46079

Follow up on recent Minuit 2 code changes #46079

guitargeek commented Sep 20, 2024

cmsbuild commented Sep 20, 2024 •

edited

Loading

cmsbuild commented Sep 20, 2024

cmsbuild commented Sep 20, 2024

smuzaffar commented Sep 23, 2024

cmsbuild commented Sep 23, 2024

cmsbuild commented Sep 23, 2024

smuzaffar Sep 23, 2024

iarspider Oct 1, 2024

guitargeek Oct 1, 2024

guitargeek Oct 3, 2024

guitargeek commented Oct 6, 2024

cmsbuild commented Oct 6, 2024

cmsbuild commented Oct 6, 2024

smuzaffar commented Oct 6, 2024

cmsbuild commented Oct 6, 2024

jfernan2 commented Oct 7, 2024 •

edited

Loading

smuzaffar commented Oct 10, 2024

perrotta commented Oct 10, 2024

cmsbuild commented Oct 10, 2024

mandrenguyen commented Oct 10, 2024

Follow up on recent Minuit 2 code changes #46079

Follow up on recent Minuit 2 code changes #46079

Conversation

guitargeek commented Sep 20, 2024

cmsbuild commented Sep 20, 2024 • edited Loading

cmsbuild commented Sep 20, 2024

cmsbuild commented Sep 20, 2024

smuzaffar commented Sep 23, 2024

cmsbuild commented Sep 23, 2024

cmsbuild commented Sep 23, 2024

Build

Clang Build

smuzaffar Sep 23, 2024

Choose a reason for hiding this comment

iarspider Oct 1, 2024

Choose a reason for hiding this comment

guitargeek Oct 1, 2024

Choose a reason for hiding this comment

guitargeek Oct 3, 2024

Choose a reason for hiding this comment

guitargeek commented Oct 6, 2024

cmsbuild commented Oct 6, 2024

cmsbuild commented Oct 6, 2024

smuzaffar commented Oct 6, 2024

cmsbuild commented Oct 6, 2024

Comparison Summary

jfernan2 commented Oct 7, 2024 • edited Loading

smuzaffar commented Oct 10, 2024

perrotta commented Oct 10, 2024

cmsbuild commented Oct 10, 2024

mandrenguyen commented Oct 10, 2024

cmsbuild commented Sep 20, 2024 •

edited

Loading

jfernan2 commented Oct 7, 2024 •

edited

Loading