[Minuit2] Reduce boilerplate code by removing redundant overloads #16443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A `MnUserParameters` instance implicitly converts to a `MnUserParameterState`.
guitargeek
requested review from
lmoneta,
bellenot and
dpiparo
as code owners
guitargeek
changed the title
In the unlikeliy case that users were relying on these functions, they can easily migrate to the overload that takes `MnUserParameterState` without any further overhead just placing some curly brackets. Since this overload also exists in older ROOT versions, this is a backwards compatible change on the user side that helps us to keep Minuit 2 code clean.
guitargeek
force-pushed
the
minuit2_constructors
branch
from
74d0800 to
c443317
Compare
2 tasks
Test Results 13 files 13 suites 3d 3h 4m 31s ⏱️ For more details on these failures, see this check. Results for commit c443317. |
mdessole
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the unlikeliy case that users were relying on these functions, they
can easily migrate to the overload that takes
MnUserParameterStatewithout any further overhead just placing some curly brackets. Since
this overload also exists in older ROOT versions, this is a backwards
compatible change on the user side that helps us to keep Minuit 2 code
clean.