Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the colors for iCubV2_5 and iCubV3 #217

Merged
merged 2 commits into from
Jan 28, 2022

Conversation

GiulioRomualdi
Copy link
Member

@GiulioRomualdi GiulioRomualdi commented Jan 28, 2022

This PR closes #216 and required robotology/simmechanics-to-urdf#51 to properly work

In detail, this PR defines the colors for each link of the robots. I've chosen the color arbitrally let me know if you prefer a different palette.

After this PR and robotology/idyntree#961 if iCub is loaded in the iDynTree visualizer we will get:

meshcat (1)
meshcat

TODO

cc @robotology/iit-artificial-mechanical-intelligence @Nicogene

@traversaro
Copy link
Member

traversaro commented Jan 28, 2022

The color for iCubV2_5 seems suspisciously iCubGenova04 specific. :D
However, for me the one that does the job decide which color to pick, so I do not see a big problem with this color. Just pinging @pattacini and @Nicogene for a double check.

@pattacini
Copy link
Member

Just pinging @pattacini for a double check.

Fine with me too 👍🏻
(although I personally dislike the iCub in red 😄 why did you choose it for iCubGenova04!)

@traversaro
Copy link
Member

Note that all the link of the model will remain "gray" when displayed in Classic Gazebo due to gazebosim/sdformat#526 (comment) .

@traversaro
Copy link
Member

robotology/simmechanics-to-urdf#51 was merged!

@GiulioRomualdi
Copy link
Member Author

Since the CI already uses the latest commit of simmechanics-to-urdf we can avoid to update the workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate on how to fix the colors in the urdf models
4 participants