Merging Latest #1

rishitshivesh · 2024-04-11T17:13:46Z

No description provided.

### What? Removed "When `prefetch` is set to `false`, prefetching will still occur on hover." from prefetch field documentation. ### Why? This behaviour no longer happens when using the app router. It's really misleading, since it creates the assumption that this behaviour always exists.  --------- Co-authored-by: JJ Kasper <[email protected]>

To help detect when newly added/changed assertions are flakey this adds a job to our build and test workflow to re-run them 3 times. If the changed test is an E2E test it will re-run in both development and production mode to ensure it's not flakey specifically in one of those modes. Test run with changed test can be seen here https://github.com/vercel/next.js/actions/runs/8511797725/job/23312158523?pr=63943 Closes NEXT-2973

This test flakes due to cache writing race so this uses retry instead to avoid this. x-ref: https://github.com/vercel/next.js/actions/runs/8512132584/job/23313143810?pr=63921 Closes NEXT-2974

Co-authored-by: JJ Kasper <[email protected]>

### What? This fixes an issue where the `nonce` attribute isn't set on `next/script` elements that has the `afterInteractive` (the default) strategy resulting in `<link rel="preload" as="script"/>` tags without a nonce. ### Why? For apps that uses 3rd party scripts (or any script) with a nonce loaded via `next/script` this is necessary unless you want them all to use `beforeInteractive` which isn't super nice for performance. --------- Co-authored-by: JJ Kasper <[email protected]>

### What? Match on `/_next/static/chunks/%5Broot%20of%20the%20server%5D__` instead of `/_next/static/chunks/main` while testing. ### Why? Turbopack does not use `/_next/static/chunks/main` as the name of the chunk ### How? Closes PACK-2874 --------- Co-authored-by: Jiachi Liu <[email protected]>

This auto-generated PR updates the development integration test manifest used when testing Turbopack.

This introduces an experimental router flag (`experimental.staleTimes`) to change the router cache behavior. Specifically: ```ts // next.config.js module.exports = { experimental: { staleTimes: { dynamic: <seconds>, static: <seconds>, }, }, }; ``` - `dynamic` is the value that is used when the `prefetch` `Link` prop is left unspecified. (Default 30 seconds) - `static` is the value that is used when the `prefetch` `Link` prop is `true`. (Default 5 minutes) Additional details: - Loading boundaries are considered reusable for the time period indicated by the `static` property (default 5 minutes) - This doesn't disable partial rendering support, **meaning shared layouts won't automatically be refetched every navigation, only the new segment data**. - This also doesn't change back/forward caching behavior to ensure things like scroll restoration etc still work nicely. Please see the original proposal [here](#54075 (comment)) for more information. The primary difference is that this is a global configuration, rather than a per-segment configuration, and it isn't applied to layouts. (We expect this to be a "stop-gap" and not the final router caching solution) Closes NEXT-2703

- DefinitelyTyped/DefinitelyTyped#69250 [x-ref](https://github.com/vercel/next.js/actions/runs/8525684931/job/23353333460?pr=63981#step:27:272)  Closes NEXT-2982

Since we're re-running tests a few times and in both modes this can take a while ([related run](https://github.com/vercel/next.js/actions/runs/8514892757/job/23321431099?pr=56995)), so this parallelizes by separating dev/prod into separate jobs. Closes NEXT-2975

Fixes #63854 Previously, there was no check when a path was passed with the --import-alias flag. Furthermore, the regex used before did not check for possible invalid paths. The current regex checks the following conditions: - It must follow the pattern `<prefix>/*` - The prefix cannot contain invalid characters for folders, such as: (whitespaces, /, <, >, :, ", /, \, |, ? and *) --------- Co-authored-by: JJ Kasper <[email protected]>

- Ensures we clean up the inserted file - Retries the HMR check since there's a delta between writing to the filesystem & HMR building the page.

Adds `NextConfig.experimental.ppr` and `NextConfig.experimental.staletimes` to the `NEXT_BUILD_FEATURE_USAGE` telemetry event.  Closes NEXT-2981

…ployed (#63978) Trying to submit a server action when JS is disabled (ie, no action header in the request, and in the "progressively enhanced" case) for a static resource results in a 405 error when deployed to Vercel. In the absence of an action ID header, the request content-type is used to signal that it shouldn't try and hit the static cache. However with multipart/form-data, this will include the boundary. This updates the matcher to consider a boundary string. Fixes #58814 Closes NEXT-2980

### Why? The output layout breaks when running `next build --debug` #### Current ```sh ✓ Generating static pages (10/10) Finalizing page optimization . Collecting build traces .Redirects ┌ source: /:path+/ ├ destination: /:path+ └ permanent: true ✓ Collecting build traces ✓ Finalizing page optimization ``` #### Expected ```sh ✓ Generating static pages (4/4) Finalizing page optimization ... Collecting build traces ... Redirects ┌ source: /:path+/ ├ destination: /:path+ └ permanent: true ``` ### How? Moved the `debug` output right above the `routes` output. Also, ensured that the output layout has a consistent number of line breaks (example below marked as `>`): > Two line breaks for the next `option`, a single line break within the same content. ```sh Collecting build traces ... > > Redirects ┌ source: /:path+/ ├ destination: /:path+ └ permanent: true > ┌ source: /redirects ├ destination: / └ permanent: true > > Headers ┌ source: / └ headers: └ x-custom-headers: headers > > Rewrites ┌ source: /rewrites └ destination: / > > Route (app) Size First Load JS ┌ ○ / 141 B 86.2 kB └ ○ /_not-found 876 B 86.9 kB ``` Fixes #63192 ---------

This ensures we don't attempt passing a closed body to a Request/Response object when a request is aborted as this triggers the disturbed/locked error condition. <details> <summary>Example error</summary> ```sh TypeError: Response body object should not be disturbed or locked at extractBody (node:internal/deps/undici/undici:4507:17) at new Request (node:internal/deps/undici/undici:5487:48) at new NextRequest (/private/var/folders/cw/z0v1fby13ll4ytx_j3t8hhqh0000gn/T/next-install-d72b2dfb54a1417294505ab189942a38fd6bc139c24b9a8089fc3248568ff902/node_modules/.pnpm/file+..+next-repo-aef41a0c8a591889bcb0dc2e751aa71aa1c2e78c82d9e9b2fe3515c3d40f6c03+packages+n_wd7e7pnjmf2re4cc3l4tp6yzqe/node_modules/next/dist/server/web/spec-extension/request.js:33:14) at NextRequestAdapter.fromNodeNextRequest (/private/var/folders/cw/z0v1fby13ll4ytx_j3t8hhqh0000gn/T/next-install-d72b2dfb54a1417294505ab189942a38fd6bc139c24b9a8089fc3248568ff902/node_modules/.pnpm/file+..+next-repo-aef41a0c8a591889bcb0dc2e751aa71aa1c2e78c82d9e9b2fe3515c3d40f6c03+packages+n_wd7e7pnjmf2re4cc3l4tp6yzqe/node_modules/next/dist/server/web/spec-extension/adapters/next-request.js:94:16) at NextRequestAdapter.fromBaseNextRequest (/private/var/folders/cw/z0v1fby13ll4ytx_j3t8hhqh0000gn/T/next-install-d72b2dfb54a1417294505ab189942a38fd6bc139c24b9a8089fc3248568ff902/node_modules/.pnpm/file+..+next-repo-aef41a0c8a591889bcb0dc2e751aa71aa1c2e78c82d9e9b2fe3515c3d40f6c03+packages+n_wd7e7pnjmf2re4cc3l4tp6yzqe/node_modules/next/dist/server/web/spec-extension/adapters/next-request.js:70:35) at doRender (/private/var/folders/cw/z0v1fby13ll4ytx_j3t8hhqh0000gn/T/next-install-d72b2dfb54a1417294505ab189942a38fd6bc139c24b9a8089fc3248568ff902/node_modules/.pnpm/file+..+next-repo-aef41a0c8a591889bcb0dc2e751aa71aa1c2e78c82d9e9b2fe3515c3d40f6c03+packages+n_wd7e7pnjmf2re4cc3l4tp6yzqe/node_modules/next/dist/server/base-server.js:1365:73) ``` </details> Fixes: #63481 Closes NEXT-2984 Closes NEXT-2904

This test could flake as it's racing the fallback data loading and the initial assertion checking the initial fallback text so this skips waiting for hydration to allow checking fallback text faster. x-ref: https://github.com/vercel/next.js/actions/runs/8529790447/job/23366315476?pr=64000 Closes NEXT-2985

## What? Both of these run on a schedule that is before the start of the day in Europe and after usual office hours in the US, meaning we have a lot of leftover idle machines at that point that can make this test run quicker.  Closes NEXT-2967

## What AMP is not supported with Turbopack. The knex example uses `@next/env` so it needs to be installed.  Closes NEXT-2989

Currently we aren't detecting the draft mode case properly in `unstable_cache` so the cache is unexpectedly being leveraged. This ensures we bypass the cache for `unstable_cache` in draft mode the same way we do for the fetch cache handling. Fixes: #60445 Closes NEXT-2987

@steve-marmalade

### What When triggering an interception route that has a parent with dynamic params, and then later going to "refresh" the tree, either by calling `router.refresh` or revalidating in a server action, the refresh action would silently fail and the router would be in a bad state. ### Why Because of the dependency that interception routes currently have on `FlightRouterState` for dynamic params extraction, we need to make sure the refetch has the full tree so that it can properly extract earlier params. Since the refreshing logic traversed parallel routes and scoped the refresh to that particular segment, it would skip over earlier segments, and so when the server attempted to diff the tree, it would return an updated tree that corresponded with the wrong segment (`[locale]` rather than `["locale", "en", "d]`). Separately, since a page segment might be `__PAGE__?{"locale": "en"}` rather than just `__PAGE__`, this updates the refetch marker logic to do a partial match on the page segment key. ### How This keeps a reference to the root of the updated tree so that the refresh always starts at the top. This has the side effect of re-rendering more data when making the "stale" refetch request, but this is necessary until we can decouple `FlightRouterState` from interception routes. shout-out to @steve-marmalade for helping find this bug and providing excellent Replays to help track it down 🙏 x-ref: - #63900  Closes NEXT-2986

"const loginSegment=" should be singular, because there is **useSelectedLayoutSegment** in the example, not **useSelectedLayoutSegments**  --------- Co-authored-by: JJ Kasper <[email protected]>

> Note: Did not add additional tests or make many changes to the utils, possible refactoring on the following PR. This PR split the legacy tests into four sections to improve the maintenance and concurrency of CNA tests: - `prompts`: target prompt interactions. `Y/n` - `examples`: target `--example` and `--example-path` flags. - `templates`: target the flag values such as `--app`, `--eslint`, etc. - `package-manager`: target package managers: npm, pnpm, yarn, bun --------- Co-authored-by: JJ Kasper <[email protected]>

… key (#63547) ## Why? When we fetch the same cache key (URL) but add an additional tag, the revalidation does not re-fetch correctly (the bug just uses in-memory cache again) when deployed. :repro: → https://github.com/lostip/nextjs-revalidation-demo/tree/main --------- Co-authored-by: Ethan Arrowood <[email protected]>

Provides a `revalidateReason` argument to `getStaticProps` ("stale" | "on-demand" | "build"). - Build indicates it was run at build time - On-demand indicates it was run as a side effect of [on-demand revalidation](https://nextjs.org/docs/pages/building-your-application/data-fetching/incremental-static-regeneration#on-demand-revalidation) - Stale indicates the resource was considered stale (either due to being in dev mode, or an expired revalidate period) This will allow changing behavior based on the context in which it's called. Closes NEXT-1900

… alphabetical (#64264) ## Why? This fixes the ordering of `--experimental-debug-memory-usage` so the help output for experimental options are alphabetical/ordered properly (grouped at the end). - Related #63869 Closes NEXT-3054

## Why? Forgot to add this change in here → #64264. Closes NEXT-3055

* vercel/turborepo#7912  * vercel/turborepo#7914

`functionaility` -> `functionality` `programatically` -> `programmatically` `recored` -> `record` `specfy` -> `specify`

This fixes a wrong route in the [staleTimes](https://nextjs.org/docs/app/api-reference/next-config-js/staleTimes) doc Co-authored-by: Sam Ko <[email protected]>

## What? Currently any configuration issue like including `.babelrc` was not highlighted during Turbopack build. This PR solves that issue as well as ensuring the warnings are not double-logged because of a change that was supposed to be development-only.  Closes NEXT-3049

This auto-generated PR updates the development integration test manifest used when testing Turbopack.

This auto-generated PR updates font data with latest available

## What? Updates the manifest with the `test/integration` run.  Closes NEXT-3058

### What CSS imports in components that loaded by `next/dynamic` in client components will cause the css are missing initial in SSR, and loaded later on client side which will lead to FOUC. This PR fixes the issue and get CSS preloaded in the SSR for dynamic components. ### Why The CSS from client components that created through `next/dynamic` are not collected in the SSR, unlike RSC rendering we already collect the CSS resources for each entry so we included them in the server rendering so the styles are availble at that time. But for client components, we didn't traverse all the client components and collect the CSS resources. In pages router we kinda collect all the dynamic imports and preload them during SSR, but this approach is not able to be applied to app router due to different architecture. Since we already have all the dynamic imports info and their related chunks in react-loadable-manifest, so we can do the similar "preloading" thing in app router. We use the current dynamic module key (`app/page.js -> ../components/foo.js`) which created by SWC transform and match it in the react loadable manifest that accessed from `AsyncLocalStorage`, to get the css files created by webpack then render them as preload styleshee links. In this way we can SSR all the related CSS resources for dynamic client components. The reason we pass down the react loadable manifest through `AsyncLocalStorage` is that it's sort of exclude the manifest from RSC payload as it's not required for hydration, but only required for SSR. Note: this issue only occurred in dynamic rendering case for client components. ### Other Changes Overview - Change the react loadable manifest key from pages dir based relative path to a source dir based relative path, to support cases with both directory or only one of them Closes NEXT-2578 Fixes #61212 Fixes #61111 Fixes #62940 Replacement for #64021 but only with production test

## What? Updates the loader documentation to the format.  Closes NEXT-3061

Follow up for #64294 to make turbopack side work as well --------- Co-authored-by: Tobias Koppers <[email protected]>

### What? align integration tests with e2e test command-wise ### Why? ### How? Closes PACK-2929 --------- Co-authored-by: Balázs Orbán <[email protected]>

…efault function (#64036)  fixes #63803 ## What I do? - If the loader file export the function as `named`, Next.js throws the error. - But this error is a bit confusing for the developers. - So I open this PR for showing the accurate error message. ## AS-IS / TO-BE ### AS-IS ``` TypeError: Cannot use 'in' operator to search for '__next_img_default' in undefined ``` <img width="1202" alt="스크린샷 2024-03-28 16 10 53" src="https://github.com/vercel/next.js/assets/33178048/e7c81cb5-7976-46ff-b86f-9c8fd9a7a681"> ### TO-BE ``` Error: The loader file must export a default function that returns a string. See more info here: https://nextjs.org/docs/messages/invalid-images-config ``` <img width="500" alt="스크린샷 2024-03-28 16 10 53" src="https://github.com/vercel/next.js/assets/33178048/c391e61b-6a44-4f85-8600-28ab6cb5b0eb"> --------- Co-authored-by: Steven <[email protected]>

# Turbopack * vercel/turborepo#7409  * vercel/turborepo#7920  * vercel/turborepo#7929  * vercel/turborepo#7926  * vercel/turborepo#7925  * vercel/turborepo#7928  * vercel/turborepo#7856  ### What? Update SWC crates. ### Why? 1. To keep in sync 2. Prepare usage of source map range mappings. getsentry/rust-sourcemap#77 ### How? Closes PACK-2860

#64131) Building on #58293, this expands escaping of url-unsafe characters in paths to “required” scripts and styles in the app renderer. This also refactors the test introduced in #58293 and expands it to include stylesheet references as well as checking resources in the head, which include special characters like turbopack references like `[turbopack]`. Test Plan: `TURBOPACK=1 pnpm test-dev test/e2e/app-dir/resource-url-encoding` Closes PACK-2911

Closes PACK-2932

### What? This adds a script that first gets a list of changed files compared to our base branch (`canary`) in PRs and identifies related test files by looking them up from a `related-tests-manifest.json`, then runs them. ### Why? We would like to be able to run related E2E tests when certain files change, so we can test deployment stability. NOTE: We still want to run all E2E tests on PRs, but this script can be used to also test deployments for hot paths. Since these tests can take up to [3-4 hours](https://github.com/vercel/next.js/actions/workflows/test_e2e_deploy.yml), we aim to run a subset of these tests first. Closes NEXT-2947

### What Bump the edge runtime manifest version and add `environments` property to each route for inlining values for deployment build. ### Why In edge runtime, extract the preview props into edge functions manifest that holding the non-deterministic inline values, then the output build will be more deterministic that helps deployment speed x-ref: vercel/vercel#11390 x-ref: vercel/vercel#11395 Closes NEXT-3012 Closes NEXT-1912

Reverts #63790

Co-authored-by: Balázs Orbán <[email protected]>

…tter title (#64331) Like the No.2 point mentioned in #63489, metadata's title and description should be the last fallback, if you specify `title` or `description` in `openGraph` but not in `metadata.twitter`, they should inherit from open graph first. For `metadata.twitter`'s fallback order should be: twitter's title/description > opengraph's title/description > metadata's title/description Resolves #63489 Closes NEXT-3073

### What? * remove custom next-* conditions * add `foreign` condition * allow `false` in turbo.rules * improve schema for turbo.rules ### Why? ### How? Closes PACK-2913 --------- Co-authored-by: Tim Neutkens <[email protected]>

This ensures we don't un-necessarily re-run the `build-native` job across all CIs from cache misses while a build is pending. Closes NEXT-3080

nphmuller and others added 30 commits April 1, 2024 11:37

Tweak flakey on-demand revalidate test (#63953)

e0d4b4f

This test flakes due to cache writing race so this uses retry instead to avoid this. x-ref: https://github.com/vercel/next.js/actions/runs/8512132584/job/23313143810?pr=63921 Closes NEXT-2974

v14.2.0-canary.52

f4aeebf

Update Turbopack development test manifest (#63959)

944159a

This auto-generated PR updates the development integration test manifest used when testing Turbopack.

Fix the command to run next build with Node.js --heap-prof flag (#63982)

fbfd1b2

v14.2.0-canary.53

94b19bb

v14.2.0-canary.54

2db296e

fix(log): skip logging non-route requests (#63973)

add2e6e

docs: add link to Next.js Learn repo in issue template switcher (#63964)

d0adfa2

v14.2.0-canary.55

e8ffd33

samcx and others added 29 commits April 9, 2024 16:36

docs(cli): re-order profile to match help output (#64267)

5ee8c4b

## Why? Forgot to add this change in here → #64264. Closes NEXT-3055

update turbopack (#64257)

dedf385

* vercel/turborepo#7912  * vercel/turborepo#7914

v14.2.0-canary.64

167ea33

chore(docs): update wrong route in staleTimes.mdx (#64278)

e1e3332

This fixes a wrong route in the [staleTimes](https://nextjs.org/docs/app/api-reference/next-config-js/staleTimes) doc Co-authored-by: Sam Ko <[email protected]>

Update Turbopack development test manifest (#64285)

6ddf2b7

This auto-generated PR updates the development integration test manifest used when testing Turbopack.

Update font data (#64277)

7e49208

This auto-generated PR updates font data with latest available

[turbopack] Fix css FOUC in dynamic component (#64021)

a7107a3

Follow up for #64294 to make turbopack side work as well --------- Co-authored-by: Tobias Koppers <[email protected]>

add test-turbo command (#64284)

0c88131

### What? align integration tests with e2e test command-wise ### Why? ### How? Closes PACK-2929 --------- Co-authored-by: Balázs Orbán <[email protected]>

v14.2.0-canary.65

22754fa

Add Ben's handle to labeler (#64312)

2670e1c

Closes PACK-2932

Revert "build: Update swc_core to v0.90.30" (#64329)

6224b9e

Reverts #63790

Docs: Instructions on how to generate turbopack trace file (#64325)

38850bf

Co-authored-by: Balázs Orbán <[email protected]>

v14.2.0-canary.66

265d7b9

Turbopack: import webpack loader rules conditions (#64205)

b912492

### What? * remove custom next-* conditions * add `foreign` condition * allow `false` in turbo.rules * improve schema for turbo.rules ### Why? ### How? Closes PACK-2913 --------- Co-authored-by: Tim Neutkens <[email protected]>

Ensure build-native is in needs properly (#64357)

83675ce

This ensures we don't un-necessarily re-run the `build-native` job across all CIs from cache misses while a build is pending. Closes NEXT-3080

rishitshivesh merged commit 9152216 into rishitshivesh:canary Apr 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merging Latest #1

Merging Latest #1

rishitshivesh commented Apr 11, 2024

Merging Latest #1

Merging Latest #1

Conversation

rishitshivesh commented Apr 11, 2024