Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadata: prefer og title rather than metadata title for fallback twitter title #64331

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Apr 11, 2024

Like the No.2 point mentioned in #63489, metadata's title and description should be the last fallback, if you specify title or description in openGraph but not in metadata.twitter, they should inherit from open graph first.

For metadata.twitter's fallback order should be:

twitter's title/description > opengraph's title/description > metadata's title/description

Resolves #63489
Closes NEXT-3073

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Apr 11, 2024
@ijjk
Copy link
Member

ijjk commented Apr 11, 2024

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js fix/inherit-og-metadata Change
buildDuration 13.8s 13.9s ⚠️ +109ms
buildDurationCached 7.4s 6.1s N/A
nodeModulesSize 199 MB 199 MB ⚠️ +7.42 kB
nextStartRea..uration (ms) 400ms 398ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js fix/inherit-og-metadata Change
2453-HASH.js gzip 31.4 kB 31.4 kB N/A
3304.HASH.js gzip 181 B 181 B
3f784ff6-HASH.js gzip 53.7 kB 53.7 kB
8299-HASH.js gzip 5.1 kB 5.1 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 242 B 242 B
main-HASH.js gzip 32.2 kB 32.2 kB N/A
webpack-HASH.js gzip 1.68 kB 1.68 kB N/A
Overall change 99.3 kB 99.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js fix/inherit-og-metadata Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js fix/inherit-og-metadata Change
_app-HASH.js gzip 196 B 197 B N/A
_error-HASH.js gzip 184 B 184 B
amp-HASH.js gzip 505 B 505 B
css-HASH.js gzip 324 B 325 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 258 B 258 B
head-HASH.js gzip 352 B 352 B
hooks-HASH.js gzip 370 B 371 B N/A
image-HASH.js gzip 4.27 kB 4.27 kB
index-HASH.js gzip 259 B 259 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 314 B 312 B N/A
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 309 B 309 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 6.63 kB 6.63 kB
Client Build Manifests
vercel/next.js canary vercel/next.js fix/inherit-og-metadata Change
_buildManifest.js gzip 483 B 485 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js fix/inherit-og-metadata Change
index.html gzip 529 B 529 B
link.html gzip 541 B 541 B
withRouter.html gzip 524 B 523 B N/A
Overall change 1.07 kB 1.07 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js fix/inherit-og-metadata Change
edge-ssr.js gzip 95.6 kB 95.6 kB N/A
page.js gzip 3.06 kB 3.06 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js fix/inherit-og-metadata Change
middleware-b..fest.js gzip 625 B 625 B
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 25.5 kB 25.5 kB N/A
edge-runtime..pack.js gzip 839 B 839 B
Overall change 1.46 kB 1.46 kB
Next Runtimes
vercel/next.js canary vercel/next.js fix/inherit-og-metadata Change
app-page-exp...dev.js gzip 170 kB 171 kB N/A
app-page-exp..prod.js gzip 97.4 kB 97.4 kB N/A
app-page-tur..prod.js gzip 99.1 kB 99.2 kB N/A
app-page-tur..prod.js gzip 93.4 kB 93.4 kB N/A
app-page.run...dev.js gzip 144 kB 144 kB N/A
app-page.run..prod.js gzip 91.9 kB 91.9 kB N/A
app-route-ex...dev.js gzip 21.5 kB 21.5 kB
app-route-ex..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 15.2 kB 15.2 kB
app-route-tu..prod.js gzip 14.9 kB 14.9 kB
app-route.ru...dev.js gzip 21.1 kB 21.1 kB
app-route.ru..prod.js gzip 14.9 kB 14.9 kB
pages-api-tu..prod.js gzip 9.55 kB 9.55 kB
pages-api.ru...dev.js gzip 9.82 kB 9.82 kB
pages-api.ru..prod.js gzip 9.55 kB 9.55 kB
pages-turbo...prod.js gzip 22.5 kB 22.5 kB
pages.runtim...dev.js gzip 23.1 kB 23.1 kB
pages.runtim..prod.js gzip 22.5 kB 22.5 kB
server.runti..prod.js gzip 51.3 kB 51.3 kB
Overall change 251 kB 251 kB
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js fix/inherit-og-metadata Change
0.pack gzip 1.58 MB 1.58 MB ⚠️ +1.55 kB
index.pack gzip 107 kB 106 kB N/A
Overall change 1.58 MB 1.58 MB ⚠️ +1.55 kB
Diff details
Diff for middleware.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js
failed to diff
Diff for app-page-exp..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page-tur..time.prod.js

Diff too large to display

Diff for app-page.runtime.dev.js

Diff too large to display

Diff for app-page.runtime.prod.js

Diff too large to display

Commit: 3272298

@ijjk
Copy link
Member

ijjk commented Apr 11, 2024

Failing test suites

Commit: 3272298

TURBOPACK=1 pnpm test-start test/e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts (turbopack)

  • parallel-routes-and-interception > route intercepting > should render modal when paired with parallel routes
Expand output

● parallel-routes-and-interception › route intercepting › should render modal when paired with parallel routes

thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  774 |       })
  775 |
> 776 |       it('should render modal when paired with parallel routes', async () => {
      |       ^
  777 |         const browser = await next.browser(
  778 |           '/intercepting-parallel-modal/vercel'
  779 |         )

  at it (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:776:7)
  at describe (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:623:5)
  at fn (lib/e2e-utils.ts:328:5)
  at describe (lib/e2e-utils.ts:321:3)
  at Object.<anonymous> (e2e/app-dir/parallel-routes-and-interception/parallel-routes-and-interception.test.ts:5:19)

Read more about building and testing Next.js in contributing.md.

@huozhi huozhi marked this pull request as ready for review April 11, 2024 13:24
@huozhi huozhi changed the title Prefer og title rather than metadata title for fallback twitter title metadata: prefer og title rather than metadata title for fallback twitter title Apr 11, 2024
@huozhi huozhi enabled auto-merge (squash) April 11, 2024 13:29
@huozhi huozhi disabled auto-merge April 11, 2024 14:07
@huozhi huozhi merged commit ce81bbb into canary Apr 11, 2024
79 of 80 checks passed
@huozhi huozhi deleted the fix/inherit-og-metadata branch April 11, 2024 14:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using open graph metadata results in duplicate metadata for twitter
2 participants