Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix edge condition in environment #7912

Merged
merged 1 commit into from
Apr 8, 2024
Merged

fix edge condition in environment #7912

merged 1 commit into from
Apr 8, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 8, 2024

Description

provide correct conditions for edge

Testing Instructions

Closes PACK-2915

Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 11:19am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 11:19am
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Apr 8, 2024 11:19am
examples-designsystem-docs ⬜️ Ignored (Inspect) Apr 8, 2024 11:19am
examples-gatsby-web ⬜️ Ignored (Inspect) Apr 8, 2024 11:19am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Apr 8, 2024 11:19am
examples-native-web ⬜️ Ignored (Inspect) Apr 8, 2024 11:19am
examples-svelte-web ⬜️ Ignored (Inspect) Apr 8, 2024 11:19am
examples-tailwind-web ⬜️ Ignored (Inspect) Apr 8, 2024 11:19am
examples-vite-web ⬜️ Ignored (Inspect) Apr 8, 2024 11:19am

Copy link
Contributor

github-actions bot commented Apr 8, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented Apr 8, 2024

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Apr 8, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@sokra sokra merged commit 0a7fd93 into main Apr 8, 2024
48 of 50 checks passed
@sokra sokra deleted the sokra/fix-edge-conditions branch April 8, 2024 13:22
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Apr 9, 2024
* vercel/turborepo#7912 <!-- Tobias Koppers - fix
edge condition in environment -->
* vercel/turborepo#7914 <!-- hrmny - feat: support
interop for namespace importing cjs function exports -->
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

provide correct conditions for edge
### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2915
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

provide correct conditions for edge
### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2915
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

provide correct conditions for edge
### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2915
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

provide correct conditions for edge
### Testing Instructions

<!--
  Give a quick description of steps to test your changes.
-->


Closes PACK-2915
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants