Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual Memory ACT #11

Open
2 of 13 tasks
jjscheel opened this issue Mar 16, 2023 · 42 comments
Open
2 of 13 tasks

Virtual Memory ACT #11

jjscheel opened this issue Mar 16, 2023 · 42 comments
Assignees

Comments

@jjscheel
Copy link
Contributor

jjscheel commented Mar 16, 2023

Technical Group

Privileged Spec IC

ratification-pkg

Virtual Memory

Technical Liaison

Dan Lustig, Andrea Mondelli

Task Category

Arch Tests

Task Sub Category

  • gcc
  • binutils
  • gdb
  • intrinsics
  • Java
  • KVM
  • ld
  • llvm
  • Linux kernel
  • QEMU
  • Spike

Ratification Target

4Q2021

Statement of Work (SOW)

SOW: link

SOW Signoffs: (delete those not needed)

  • Task group liaison sign-off date:
  • Development partner sign-off date:
  • ACT SIG sign-off date (if ACT work):

Waiver

  • Freeze
  • Ratification

Pull Request Details

@jjscheel
Copy link
Contributor Author

Status from Umer:

VM ACTs: Tests are getting developed under supervision of Allen. PR is expected in the next month hopefully.

@jjscheel jjscheel assigned jjscheel and Abdulwadoodd and unassigned jjscheel Apr 12, 2023
@UmerShahidengr
Copy link

Update Apr 25th, 2023 => The Trap handler PR has been merged successfully. It has removed all known bugs related to VM and ePMP trap. The PR details are here
Next week task => Complete macro definitions to setup page tables for SV39 and SV32, and start developing the tests according to the developed test plan

@jjscheel
Copy link
Contributor Author

Update from Allen:

  1. Got the next version of the trap handler working and tested (With help for 10xe folks) and merged.
    It is now possible to write tests of virtual memory, transition between protections mode easily, and write tests that can partition > permissions inside test code and data.
  2. continue to partition and Test Format Spec into ACT Developer Spec and ACT User Spec, and continue to get new chair up to speed
  3. no
  4. I don't have any dates....

@jjscheel
Copy link
Contributor Author

jjscheel commented May 1, 2023

My sense is that this work won't be done by next meeting on May 9. So, let's try a target of May 23.

@UmerShahidengr, thoughts?

@UmerShahidengr
Copy link

I couldn't understand what do you mean by "done" here.
For this week's target, the macros for SV39 and SV32 have been updated, so there are no unresolved dependencies in writing ACTs for VM (for now). Some of the baseline tests are available here, but they are not ready for the PR yet. We are testing it through Sail log, and not putting anything in the signature file yet. I hope these tests will be updated in this week and some of the new tests will also be added for SV32.
But this project is still a long way away from completion (if you are calling completion as "done") as there are so many test and corner cases to cover but we will try to do our first PR during the next week.

@jjscheel
Copy link
Contributor Author

jjscheel commented May 2, 2023

@UmerShahidengr, great question. I should have been more specific.

I was asking when the PR would be submitted and accepted, i.e. "done with the all work". Do you have a target here?

@UmerShahidengr
Copy link

Progress Update May 7th, 2023 => Still working on defining the macros for SV39 page table setup.
Next Week goal => Develop basic tests for SV32 (RV32) and make the first PR.

In regards to the question of @jjscheel , our initial deadline for completing this work was 2023Q2 but it will take more time. @Abdulwadoodd can you comment on any target deadline?

@UmerShahidengr
Copy link

Update May 23rd, 2023 => Not much update on this task yet.

@jjscheel
Copy link
Contributor Author

Thanks, @UmerShahidengr. Removed from today's agenda. Touch base next meeting.

@Abdulwadoodd , do you have a target completion date for all work?

@UmerShahidengr
Copy link

Update ⇾ June 12th, 2023:
@Abdulwadoodd is busy in client's project, so we have been searching for a helping hand within 10xE who will help him in this project. Sa far, there is not much update in this.

@jjscheel
Copy link
Contributor Author

No worries. We can just let this sit at the time being. Thanks for update.

@jjscheel
Copy link
Contributor Author

Marking as "Blocked" due to current constraints identified.

@jjscheel jjscheel moved this from As-planned to Late in RISC-V DevPartner Work Jun 12, 2023
@jjscheel jjscheel moved this from Late to Blocked in RISC-V DevPartner Work Jun 12, 2023
@UmerShahidengr
Copy link

Update ⇾ July 11th, 2023
No update.

@UmerShahidengr
Copy link

Update ⇾ December 12th, 2023
The review process is going on smoothly.

@UmerShahidengr
Copy link

Update ⇾ January 30th, 2024
The review process is going on.

@UmerShahidengr
Copy link

Update ⇾ March 5th, 2024
Stalled.

@jjscheel
Copy link
Contributor Author

jjscheel commented Mar 5, 2024

@UmerShahidengr, is this stalled in the community? If so, is it all pieces or some?

@allenjbaum, FYI.

@jjscheel jjscheel moved this from As-planned to Blocked in RISC-V DevPartner Work Mar 5, 2024
@UmerShahidengr
Copy link

It is not stalled in the community, it is stalled from our side. After converting the coverpoints of PMP, @MuhammadHammad001 will translate VM coverpoints according to the new template too.

@UmerShahidengr
Copy link

Update ⇾ April 2nd, 2024
Stalled from our side. Coverpoint definitions will be resumed once PMP is done

@jjscheel
Copy link
Contributor Author

jjscheel commented Apr 3, 2024

Thanks for the update @UmerShahidengr. Please let us know when @MuhammadHammad001 starts his work on coverpoints.

@UmerShahidengr
Copy link

Update April 30th, 2024:
Since pmp work is complete from our side, @MuhammadHammad001 has been working on sv32 coverpoints which will be delivered before the next meeting

@UmerShahidengr
Copy link

Update June 11th, 2024:
@MuhammadHammad001 has been working on this one in parallel with PMP.

@jjscheel
Copy link
Contributor Author

@UmerShahidengr, what is the status of the sv32 coverpoints? What remains to be completed?

@UmerShahidengr
Copy link

@jjscheel we have been targeting this quarter to complete these coverpoints, @MuhammadHammad001 has been working on this one.

@jjscheel
Copy link
Contributor Author

Thanks. Does "this quarter" mean by end of June (2 weeks) or in the next 90 days?

@jjscheel jjscheel moved this from Blocked to As-planned in RISC-V DevPartner Work Jun 12, 2024
@UmerShahidengr
Copy link

Our plan was to conclude it in this quarter means by the end of June but I doubt it will take some more time

@UmerShahidengr
Copy link

Update June 25th, 2024
@MuhammadHammad001 has been working on this one, the work is in progress for sv32 coverpoints.

@UmerShahidengr
Copy link

Update July 23rd, 2024:
@MuhammadHammad001 will be unavailable for next few weeks due to medical emergency in his family. This work will be resumed after the next month.

@jjscheel
Copy link
Contributor Author

I'm sorry to hear that. Thanks for the update.

@jjscheel jjscheel moved this from As-planned to Blocked in RISC-V DevPartner Work Jul 24, 2024
@UmerShahidengr UmerShahidengr moved this from Blocked to Late in RISC-V DevPartner Work Oct 1, 2024
@UmerShahidengr
Copy link

Update October 29th, 2024:
The PR of SV32 will be merged in the next release meeting of SIG ARCH.
CC @allenjbaum

@UmerShahidengr
Copy link

PR of SV32 ACTs and coverpoints is still pending and awaiting final review by @allenjbaum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Late
Development

No branches or pull requests

4 participants