Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-implement scheme component validations #89

Merged
merged 3 commits into from
Oct 26, 2017
Merged

Re-implement scheme component validations #89

merged 3 commits into from
Oct 26, 2017

Conversation

skalee
Copy link
Contributor

@skalee skalee commented Oct 26, 2017

No description provided.

skalee added 3 commits October 26, 2017 11:19
@skalee
Re-implement the :scheme validation option
94e7bb5 
The :scheme option constraints schemes allowed for given URI.
@skalee
Remove a confusing leftover from specs
3410492 
The :scheme option has been temporarily removed in 6839f41
(pull request #83) and greatly reworked since then.  In the previous
implementation, providing it in these examples was an odd necessity.
Now it's only a confusing and troublesome leftover, which is being
removed now.
@skalee
Features for scheme component constraints
027f67c
@codecov
Copy link

codecov bot commented Oct 26, 2017 •
edited
Loading

Codecov Report

Merging #89 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #89      +/-   ##
=========================================
+ Coverage   99.42%   99.5%   +0.07%     
=========================================
  Files          10      10              
  Lines         174     201      +27     
=========================================
+ Hits          173     200      +27     
  Misses          1       1
Impacted Files Coverage Δ
...b/uri_format_validator/validators/uri_validator.rb 100% <100%> (ø) ⬆️
spec/uri_validator_spec.rb 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f2fbc8...027f67c. Read the comment docs.

@skalee skalee merged commit cfb50ad into master Oct 26, 2017
@skalee skalee deleted the scheme branch October 26, 2017 10:07
@skalee skalee mentioned this pull request Oct 26, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@skalee