Delete most of the logic, and clean-up what's left #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 25, 2017
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Error: The `Lint/InvalidCharacterLiteral` cop has been removed since it was n...
Error: The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter EnforcedStyle (for Style/Encoding) found in .rubocop.yml Style/Encoding no longer supports styles. The "never" behavior is always assumed. obsolete parameter SupportedStyles (for Style/Encoding) found in .rubocop.yml
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
=========================================
- Coverage 99.44% 99.4% -0.04%
=========================================
Files 10 10
Lines 358 168 -190
=========================================
- Hits 356 167 -189
+ Misses 2 1 -1
Continue to review full report at Codecov.
|
houndci-bot
reviewed
Oct 25, 2017
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Error: The `Lint/InvalidCharacterLiteral` cop has been removed since it was n...
Error: The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter EnforcedStyle (for Style/Encoding) found in .rubocop.yml Style/Encoding no longer supports styles. The "never" behavior is always assumed. obsolete parameter SupportedStyles (for Style/Encoding) found in .rubocop.yml
houndci-bot
reviewed
Oct 25, 2017
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Error: The `Lint/InvalidCharacterLiteral` cop has been removed since it was n...
Error: The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter EnforcedStyle (for Style/Encoding) found in .rubocop.yml Style/Encoding no longer supports styles. The "never" behavior is always assumed. obsolete parameter SupportedStyles (for Style/Encoding) found in .rubocop.yml
houndci-bot
reviewed
Oct 25, 2017
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Error: The `Lint/InvalidCharacterLiteral` cop has been removed since it was n...
Error: The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered. (obsolete configuration found in .rubocop.yml, please update it) obsolete parameter EnforcedStyle (for Style/Encoding) found in .rubocop.yml Style/Encoding no longer supports styles. The "never" behavior is always assumed. obsolete parameter SupportedStyles (for Style/Encoding) found in .rubocop.yml
houndci-bot
reviewed
Oct 25, 2017
| def validate_retrievable(option, uri) | ||
| fail_unless Reacher.new(uri).retrievable? if option | ||
| invalid unless Reacher.new(uri).retrievable? if option |
There was a problem hiding this comment.
Avoid using nested modifiers.
Avoid modifier if after another conditional.
Single `invalid` method is enough.
The allow_nil/blank options are standard Active Model features. There aren't implemented in this gem, thus they don't need testing.
Validating URLs requires additional constraints. Not all valid URIs with http(s) scheme set are valid URLs. We used to have a RegExp for that, but it has been proven to be way too limited. Disabling these specs for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous regular-expression-based implementation was insufficient, and very difficult to improve. Therefore, most of it must be removed prior being rewritten from scratch.