Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-existing option from specs #87

Closed
wants to merge 1 commit into from

Conversation

skalee
Copy link
Contributor

@skalee skalee commented Oct 25, 2017

The :scheme option has been temporarily removed in 6839f41 (pull request #83). Providing it in these tests was the odd requirement of the previous implementation. Now it may be (and should be) removed from these examples as irrelevant.

The :scheme option has been temporarily removed in 6839f41
(pull request #83).  Providing it in these tests was the odd requirement
of the previous implementation.  Now it may be (and should be) removed
from these examples as irrelevant.
@skalee skalee force-pushed the remove-non-existing-option-from-specs branch from b7d2664 to d090d4d Compare October 25, 2017 20:21
@codecov
Copy link

codecov bot commented Oct 25, 2017

Codecov Report

Merging #87 into master will decrease coverage by 1.68%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   99.42%   97.74%   -1.69%     
==========================================
  Files          10       10              
  Lines         174      177       +3     
==========================================
  Hits          173      173              
- Misses          1        4       +3
Impacted Files Coverage Δ
spec/uri_validator_spec.rb 100% <100%> (ø) ⬆️
lib/uri_format_validator/reacher.rb 87.5% <0%> (-5.84%) ⬇️
...b/uri_format_validator/validators/uri_validator.rb 94.73% <0%> (-5.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b41b754...d090d4d. Read the comment docs.

@skalee
Copy link
Contributor Author

skalee commented Oct 26, 2017

This one has been already fixed in a better way in #89, closing.

@skalee skalee closed this Oct 26, 2017
@skalee skalee deleted the remove-non-existing-option-from-specs branch October 26, 2017 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant