-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split the API examples into sub-pages #2438
Conversation
56594cf
to
2d3b921
Compare
7d72daa
to
b82ef66
Compare
88adb73
to
97b9d40
Compare
76372c3
to
a64cbb6
Compare
0514372
to
3d015dc
Compare
3d015dc
to
7d1f6c3
Compare
9820fc4
to
dc3c4b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love the opening page
--- | ||
`Point2d` represents a singular point in two-dimensional space with optional color, radii, and label. `Point2d` entities will be drawn as part of the 2D Spatial SpaceView. | ||
|
||
It is compatible with [`AnnotationContext`](../../concepts/annotation-context.md). `class_id` can be used to provide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's true for most things actually, not sure if we want to repeat that text on all of them? 🤔
Sadly not all ofc..
|
||
It is compatible with [`AnnotationContext`](../../concepts/annotation-context.md). `class_id` can be used to provide | ||
colors and labels from the annotation context, and `keypoint_id` can be used to make connected edges between points. See | ||
examples in the `AnnotationContext` documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jleibs I just noticed the spurious )
in viewer-walkthrough line 240. Can you remove it?
### What Continues following the pattern established from: - #2438 Contributes to: - #2382 Preview: - https://landing-2yxomjvlz-rerun.vercel.app/preview/d8d222a/docs/reference/data_types ### Checklist * [ ] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [ ] I've included a screenshot or gif (if applicable) <!-- This line will get updated when the PR build summary job finishes. --> PR Build Summary: https://build.rerun.io/pr/2467 <!-- pr-link-docs:start --> Docs preview: https://rerun.io/preview/5eba986/docs Examples preview: https://rerun.io/preview/5eba986/examples <!-- pr-link-docs:end --> --------- Co-authored-by: Nikolaus West <[email protected]> Co-authored-by: Nikolaus West <[email protected]>
What
Preview using the latest version of landing (python code samples first, shadows around images, no glitching on scroll, etc.)
More individual component cleanup will happen in subsequent PRs.
Checklist
PR Build Summary: https://build.rerun.io/pr/2438
Docs preview: https://rerun.io/preview/5757435/docs
Examples preview: https://rerun.io/preview/5757435/examples