Split examples by language #1181

emilk · 2023-02-10T10:58:09Z

I also re-arranged the objectron python structure so that:

dataset contains the downloaded data (because that's what we use everywhere else, and it is what is in the global .gitignore)
proto contains the protobuff stuff
download_dataset.py is in the same path as main.py

TODO

compare how other examples do dataset downloading
figure out how rust objectron gets the dataset
test all python examples
test all rust examples

Checklist

I have read and agree to Contributor Guide and the Code of Conduct
I've included a screenshot or gif (if applicable)
I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

emilk · 2023-02-10T15:49:27Z

This was a lot more work than anticipated 😓

teh-cmc · 2023-02-10T17:22:44Z

I'll review carefully over the WE, I have a lot of examples-related work I want to do anyhow!

* Split out the `run` parts of the rerun library to its own file * Document that the web feature flag requires running scripts/setup_web.sh * Improve the docs of rerun and re_sdk * Describe more things * Fix warning * More docs, and split out `coordinates` into its own module * nit comment Co-authored-by: Andreas Reich <[email protected]> * Improve docstring * Improve error message * Add some spacing * For instance -> For example --------- Co-authored-by: Andreas Reich <[email protected]>

…o caching (#1187) * Mark git directories as safe for our docker_ci container * New cargo packages means a new cache key * Add CACHE_KEY everywhere and Only update cache from 1 location

* log_image_file: require named arguments * Allow logging the contents of an image file, not by path

* Add --dataset and --resize flags to colmap

* Make 'web' a default feature of the python sdk * Add sanity-checking to crates/re_web_server/build.rs * Allow crates/re_web_server/build.rs to be run from any CWD * Run setup_web.sh on the Python CI * Turn on the web feature on the CI * Only enable the web feature when building pypi package * Improve setup_web.sh * Add winget package manager to setup_web.sh * Print out what is happening * Add shell: bash * Try getting wasm-opt into the windows build * Correct path to exe * run setup_web.sh but allow it to fail --------- Co-authored-by: Jeremy Leibs <[email protected]>

* Update arrow2, arrow2_convert and polars * Patch arrow2-convert again * Add instructions for how to patch crates to Cargo.toml * Use trunk polars in patch

* Turn on python linting of examples * Fix minor lints * Mute lints about bad docstrings * Use list() instead of trivial list comprehension * ignore some lines, fix others * don't use single-letter names * ignore line * `catch:` -> `catch Exception:` * Dict comprehension * format * Docstring improvements * More docstring fixes * Docstring fixes * docstrings done! * Enable and fix more lints * One more * Clean up .flake8 file * Final cleanup of .flake8 * Also lint python scripts under scripts/ * py-format * better dicom explanation Co-authored-by: Andreas Reich <[email protected]> --------- Co-authored-by: Andreas Reich <[email protected]>

teh-cmc · 2023-02-11T17:18:25Z

…tter default one

jondo2010 · 2023-02-11T17:25:31Z

examples/python/README.md

+The simplest example is [`minimal`](minimal/main.py). You may want to start there!
+
+## Setup
+First install the Rerun Python SDK with `pip install rerun-sdk` (coming soon!)


Suggested change

First install the Rerun Python SDK with `pip install rerun-sdk` (coming soon!)

First install the Rerun Python SDK with `pip install rerun-sdk`.

Might as well pre-emptively get this right.

Question: if rerun-sdk is already published, why can't I find it on https://pypi.org/project/rerun-sdk/ ?

It's only been published on testpypi, so pip install -i https://test.pypi.org/simple/ rerun-sdk

So if pip install rerun-sdk doesn't work yet, then let's not write it yet.

jondo2010 · 2023-02-11T17:25:44Z

examples/python/README.md

+## Setup
+First install the Rerun Python SDK with `pip install rerun-sdk` (coming soon!)
+
+<!-- TODO(emilk): remove the coming soon -->


Suggested change

jondo2010 · 2023-02-11T17:33:34Z

Also need to update the links to the examples in rerun-docs/docs/getting-started/examples.md

teh-cmc · 2023-02-11T17:41:42Z

$ cargo r -p raw_mesh -- --scene lantern
    Finished dev [optimized + debuginfo] target(s) in 0.18s
     Running `target/debug/raw_mesh --scene lantern`
Error: Could not load the scene, have you downloaded the dataset? Try running the python version first to download it automatically (`examples/python/raw_mesh/main.py --scene lantern`).

$ examples/python/raw_mesh/main.py --scene lantern
downloading https://github.com/KhronosGroup/glTF-Sample-Models/blob/master/2.0/Lantern/glTF-Binary/Lantern.glb?raw=true …
loading scene /home/cmc/dev/rerun-io/rerun/examples/python/raw_mesh/dataset/lantern/lantern.glb…

$ cargo r -p raw_mesh -- --scene lantern
    Finished dev [optimized + debuginfo] target(s) in 0.17s
     Running `target/debug/raw_mesh --scene lantern`
2023-02-11T17:39:12.908731Z  INFO raw_mesh: parsing glTF scene scene="scene_#0"
2023-02-11T17:39:12.908911Z  INFO raw_mesh: logging glTF scene scene="scene_#0"

…by-language

emilk added 3 commits February 10, 2023 14:25

Split python and rust examples into separate folders

e9245db

objectron: ensure logging reaches the screen

df4737a

try fix

6e829e4

emilk force-pushed the emilk/split-examples-by-language branch from 249385f to 6e829e4 Compare February 10, 2023 13:25

emilk added 7 commits February 10, 2023 15:49

remove dead shellscript

2ae70b9

fix objectron build-script

497ed70

Fixes

a3eeb5a

Fix Rust objectron demo

9f90b82

Add readme for rust examples

1c1b95d

lint

63e3e51

fix mypy

6fa1237

emilk marked this pull request as ready for review February 10, 2023 15:55

Merge branch 'main' into emilk/split-examples-by-language

06b8785

teh-cmc self-requested a review February 10, 2023 17:10

emilk and others added 14 commits February 11, 2023 11:13

Add newlines before types, impl, fn, and docstrings

7a3041d

Update examples/requirements.txt

2bea9d7

Mark git directories as safe for our docker_ci container and fix carg…

a5dc541

…o caching (#1187) * Mark git directories as safe for our docker_ci container * New cargo packages means a new cache key * Add CACHE_KEY everywhere and Only update cache from 1 location

Run cargo check after patching pre-release (#1190)

b1557d1

Allow logging the contents of an image file, not by path (#1193)

74be952

* log_image_file: require named arguments * Allow logging the contents of an image file, not by path

Add --dataset and --resize flags to colmap (#1177)

a2a7780

* Add --dataset and --resize flags to colmap

Install web dependencies before running cargo check (#1196)

59cc8b7

Update arrow2, arrow2_convert and polars (#1189)

8bb3bf6

* Update arrow2, arrow2_convert and polars * Patch arrow2-convert again * Add instructions for how to patch crates to Cargo.toml * Use trunk polars in patch

Merge branch 'main' into emilk/split-examples-by-language

e525e3b

Update the paths in .flake8

e748f92

Merge branch 'main' into emilk/split-examples-by-language

e921307

teh-cmc added 2 commits February 11, 2023 18:23

examples/deep_sdf: sort scenes by relevance instead of lexically + be…

cbf1a51

…tter default one

examples/raw_mesh: sort scenes by relevance instead of lexically + be…

82b4a59

…tter default one

jondo2010 reviewed Feb 11, 2023

View reviewed changes

jondo2010 approved these changes Feb 11, 2023

View reviewed changes

examples/raw_mesh: now offering a higher level --scene flag

c37d567

Merge remote-tracking branch 'origin/main' into emilk/split-examples-…

79559b3

…by-language

teh-cmc approved these changes Feb 11, 2023

View reviewed changes

emilk merged commit 4fb69ee into main Feb 11, 2023

emilk deleted the emilk/split-examples-by-language branch February 11, 2023 18:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Split examples by language #1181

Split examples by language #1181

emilk commented Feb 10, 2023 •

edited

Loading

emilk commented Feb 10, 2023

teh-cmc commented Feb 10, 2023

teh-cmc commented Feb 11, 2023 •

edited

Loading

jondo2010 Feb 11, 2023

emilk Feb 11, 2023

jondo2010 Feb 11, 2023

emilk Feb 11, 2023

jondo2010 Feb 11, 2023

jondo2010 commented Feb 11, 2023

teh-cmc commented Feb 11, 2023

	First install the Rerun Python SDK with `pip install rerun-sdk` (coming soon!)
	First install the Rerun Python SDK with `pip install rerun-sdk`.

Split examples by language #1181

Split examples by language #1181

Conversation

emilk commented Feb 10, 2023 • edited Loading

TODO

Checklist

emilk commented Feb 10, 2023

teh-cmc commented Feb 10, 2023

teh-cmc commented Feb 11, 2023 • edited Loading

jondo2010 Feb 11, 2023

Choose a reason for hiding this comment

emilk Feb 11, 2023

Choose a reason for hiding this comment

jondo2010 Feb 11, 2023

Choose a reason for hiding this comment

emilk Feb 11, 2023

Choose a reason for hiding this comment

jondo2010 Feb 11, 2023

Choose a reason for hiding this comment

jondo2010 commented Feb 11, 2023

teh-cmc commented Feb 11, 2023

emilk commented Feb 10, 2023 •

edited

Loading

teh-cmc commented Feb 11, 2023 •

edited

Loading