Add --dataset and --resize flags to colmap #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
reviewed
Feb 10, 2023
emilk
reviewed
Feb 10, 2023
emilk
approved these changes
Feb 10, 2023
3 tasks
emilk
reviewed
Feb 11, 2023
| if resize: | ||
| img = cv2.imread(str(image_file)) | ||
| img = cv2.resize(img, resize) | ||
| _, encimg = cv2.imencode(".jpg", img) |
There was a problem hiding this comment.
we could also experiment with more aggressive jpeg compression to get the rrd size down further
emilk
pushed a commit
that referenced
this pull request
Feb 11, 2023
* Add --dataset and --resize flags to colmap
emilk
pushed a commit
that referenced
this pull request
Feb 11, 2023
* Add --dataset and --resize flags to colmap
emilk
added a commit
that referenced
this pull request
Feb 11, 2023
* Split python and rust examples into separate folders * objectron: ensure logging reaches the screen * try fix * remove dead shellscript * fix objectron build-script * Fixes * Fix Rust objectron demo * Add readme for rust examples * lint * fix mypy * Improve the docs of `rerun` (#1179) * Split out the `run` parts of the rerun library to its own file * Document that the web feature flag requires running scripts/setup_web.sh * Improve the docs of rerun and re_sdk * Describe more things * Fix warning * More docs, and split out `coordinates` into its own module * nit comment Co-authored-by: Andreas Reich <[email protected]> * Improve docstring * Improve error message * Add some spacing * For instance -> For example --------- Co-authored-by: Andreas Reich <[email protected]> * Add newlines before types, `impl`, `fn`, and docstrings * Update examples/requirements.txt * Mark git directories as safe for our docker_ci container and fix cargo caching (#1187) * Mark git directories as safe for our docker_ci container * New cargo packages means a new cache key * Add CACHE_KEY everywhere and Only update cache from 1 location * Run cargo check after patching pre-release (#1190) * Allow logging the contents of an image file, not by path (#1193) * log_image_file: require named arguments * Allow logging the contents of an image file, not by path * Add --dataset and --resize flags to colmap (#1177) * Add --dataset and --resize flags to colmap * Enable `--web-viewer` in the Python Wheels (#1182) * Make 'web' a default feature of the python sdk * Add sanity-checking to crates/re_web_server/build.rs * Allow crates/re_web_server/build.rs to be run from any CWD * Run setup_web.sh on the Python CI * Turn on the web feature on the CI * Only enable the web feature when building pypi package * Improve setup_web.sh * Add winget package manager to setup_web.sh * Print out what is happening * Add shell: bash * Try getting wasm-opt into the windows build * Correct path to exe * run setup_web.sh but allow it to fail --------- Co-authored-by: Jeremy Leibs <[email protected]> * Install web dependencies before running cargo check (#1196) * Update arrow2, arrow2_convert and polars (#1189) * Update arrow2, arrow2_convert and polars * Patch arrow2-convert again * Add instructions for how to patch crates to Cargo.toml * Use trunk polars in patch * Turn on and fix Python linting of examples (#1191) * Turn on python linting of examples * Fix minor lints * Mute lints about bad docstrings * Use list() instead of trivial list comprehension * ignore some lines, fix others * don't use single-letter names * ignore line * `catch:` -> `catch Exception:` * Dict comprehension * format * Docstring improvements * More docstring fixes * Docstring fixes * docstrings done! * Enable and fix more lints * One more * Clean up .flake8 file * Final cleanup of .flake8 * Also lint python scripts under scripts/ * py-format * better dicom explanation Co-authored-by: Andreas Reich <[email protected]> --------- Co-authored-by: Andreas Reich <[email protected]> * Update the paths in .flake8 * examples/deep_sdf: sort scenes by relevance instead of lexically + better default one * examples/raw_mesh: sort scenes by relevance instead of lexically + better default one * examples/raw_mesh: now offering a higher level --scene flag --------- Co-authored-by: Clement Rey <[email protected]> Co-authored-by: Andreas Reich <[email protected]> Co-authored-by: Jeremy Leibs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be able to create small rrd files from the colmap data, add a --resize flag to colmap. Also add support for arbitrary datasets including the new
colmap_fiat(which still needs to be uploaded).This both on-demand resizes the images to the appropriate resolution, and adjusts the camera projection matrix and 2d points to match.
With this PR, we can now run:
and end up with a 13M .rrd file appropriate for including in our wheels.
Checklist
CHANGELOG.md(if this is a big enough change to warrant it)