Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: regen-network/rnd-dev-team#1778
This is the second attempt to fix this issue.
The first one (#2058) attempted to set fixed versions on packages that were causing the issue. This approach only fixed the problem for dev and not for the production build, this fix has been reverted here: #2064.
The new attempt directly fixes the issue with the dependencies upgrade. In the package
@ledgerhq/live-network
there was an unhandledrequire
statement, that could not be tranformed with vite. In order to fix it we replace thehttps
as the defaultaxios
agent byagentkeepalive
which should be equivalent and allow us to replace therequire
with animport
directly. The patch has been created throughpatch-package
and applied withpostinstall
script.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...