Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unhandled https require #2066

Merged
merged 2 commits into from
Sep 6, 2023
Merged

fix: unhandled https require #2066

merged 2 commits into from
Sep 6, 2023

Conversation

flagrede
Copy link
Collaborator

@flagrede flagrede commented Sep 4, 2023

Description

Closes: regen-network/rnd-dev-team#1778

This is the second attempt to fix this issue.
The first one (#2058) attempted to set fixed versions on packages that were causing the issue. This approach only fixed the problem for dev and not for the production build, this fix has been reverted here: #2064.

The new attempt directly fixes the issue with the dependencies upgrade. In the package @ledgerhq/live-network there was an unhandled require statement, that could not be tranformed with vite. In order to fix it we replace the https as the default axios agent by agentkeepalive which should be equivalent and allow us to replace the require with an import directly. The patch has been created through patch-package and applied with postinstall script.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

  1. https://deploy-preview-2066--regen-marketplace.netlify.app/

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@netlify
Copy link

netlify bot commented Sep 4, 2023

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit fbdbce1
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/64f87587ac55d900081411b2
😎 Deploy Preview https://deploy-preview-2066--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flagrede flagrede force-pushed the fix-1778-yarn-lock2 branch 3 times, most recently from 0b3b3aa to db537bc Compare September 4, 2023 13:24
@flagrede flagrede requested a review from a team September 4, 2023 13:32
Copy link
Member

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK (dev and build/serve locally)

@flagrede flagrede force-pushed the fix-1778-yarn-lock2 branch from db537bc to c9b01b5 Compare September 5, 2023 12:48
@flagrede flagrede mentioned this pull request Sep 5, 2023
10 tasks
@flagrede flagrede force-pushed the fix-1778-yarn-lock2 branch from c9b01b5 to 3e0b00b Compare September 6, 2023 09:54
@flagrede flagrede force-pushed the fix-1778-yarn-lock2 branch from 3e0b00b to fbdbce1 Compare September 6, 2023 12:50
@flagrede flagrede merged commit b63b52d into dev Sep 6, 2023
14 checks passed
@flagrede flagrede deleted the fix-1778-yarn-lock2 branch September 6, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with fresh yarn.lock
2 participants