Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with fresh yarn.lock #1778

Closed
flagrede opened this issue Aug 30, 2023 · 2 comments · Fixed by regen-network/regen-web#2058 or regen-network/regen-web#2066
Closed

Issue with fresh yarn.lock #1778

flagrede opened this issue Aug 30, 2023 · 2 comments · Fixed by regen-network/regen-web#2058 or regen-network/regen-web#2066
Assignees
@flagrede
Labels
bug Something isn't working dev Engineering tasks

Comments

@flagrede
Copy link

flagrede commented Aug 30, 2023 •
edited
Loading

If we create a fresh yarn.lock in regen-web on dev it breaks some features of the app.

As an example go to this deploy preview and try to connect: https://deploy-preview-2038--regen-marketplace.netlify.app/
You'll get the following error: ReferenceError: require is not defined

We need to figure out the dependency upgrades that cause these issues.
@flagrede flagrede added the bug Something isn't working label Aug 30, 2023
@ryanchristo ryanchristo added the dev Engineering tasks label Aug 31, 2023
@flagrede flagrede self-assigned this Aug 31, 2023
@flagrede flagrede mentioned this issue Aug 31, 2023
Merged
10 tasks
@flagrede
Copy link
Author

flagrede commented Sep 1, 2023

Reopening this as it seems we still have issues following the yarn.lock update.

@flagrede flagrede reopened this Sep 1, 2023
@flagrede flagrede mentioned this issue Sep 4, 2023
Merged
10 tasks
@flagrede
Copy link
Author

flagrede commented Sep 5, 2023

Post estimating to 5 based on time spent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flagrede flagrede

Labels
bug Something isn't working dev Engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: yarn lock regen-network/regen-web
fix: unhandled https require regen-network/regen-web
2 participants
@flagrede @ryanchristo