fix: storybook local environment #2038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
flagrede
commented
Aug 23, 2023
flagrede
force-pushed
the
fix-1974-fix-storybook
branch
from
1cebca4 to
6759b36
Compare
flagrede
force-pushed
the
fix-1974-fix-storybook
branch
from
d3cc365 to
b4c2252
Compare
flagrede
commented
Aug 24, 2023
patches/fsevents+2.3.2.patch
Outdated
| function getFileType(flags) { | ||
| if (events.ItemIsFile & flags) return "file"; | ||
| if (events.ItemIsDir & flags) return "directory"; | ||
| + if (events.MustScanSubDirs & flags) return "directory"; |
There was a problem hiding this comment.
For more information about this change see this issue: vitejs/vite#14043
The storybook restart issue in local was related to the dependency fsevents used in chodikar (the file watcher used in storybook). The issue has been fixed in the latest version of fsevents but this version seems incompatible on linux atm so we're patching the dependency with the fix in the meantime.
|
There's still an issue with the wallet connection. |
|
Issue mentioned above was not related to the PR, will be fixed here: #2058 |
flagrede
force-pushed
the
fix-1974-fix-storybook
branch
from
5ff6831 to
daced29
Compare
|
New fix here: #2066 |
flagrede
force-pushed
the
fix-1974-fix-storybook
branch
from
daced29 to
0a3d236
Compare
|
@regen-network/rnd-dev-team the PR is ready for review again. |
flagrede
force-pushed
the
fix-1974-fix-storybook
branch
from
0a3d236 to
6287cad
Compare
blushi
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #1974
fix:
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...