-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The image and gif files shown on PyPI need to be corrected. #1558
Comments
From the following research, we have the simple way to solve this issue. ResearchI find examples that can show images and .gif on PyPI correctly. Case of showing the imageFastAPI Case of showing the .gifstreamlit-keyup Conclusion: But How to solve it? For example, the following is the such solution |
## Summary & Motivation Currently there are several images missing on our PyPI page: ![image](https://github.com/dagster-io/dagster/assets/1531373/183a6af0-30a7-4b7e-a22f-aae8a7bf195d) The PyPI page is derived from the Dagster README, which gets copied into the `long_description` field of the PyPI package. `img` elements in the README with relative URLs then can't be resolved. This PR replaces the all relative URLs in `img` tags with full URLs to github master. ## How I Tested These Changes Not sure how to directly test PyPI without releasing, but: - You can see the README still renders on this branch. - These people had the same problem/solution: reflex-dev/reflex#1558
## Summary & Motivation Currently there are several images missing on our PyPI page: ![image](https://github.com/dagster-io/dagster/assets/1531373/183a6af0-30a7-4b7e-a22f-aae8a7bf195d) The PyPI page is derived from the Dagster README, which gets copied into the `long_description` field of the PyPI package. `img` elements in the README with relative URLs then can't be resolved. This PR replaces the all relative URLs in `img` tags with full URLs to github master. ## How I Tested These Changes Not sure how to directly test PyPI without releasing, but: - You can see the README still renders on this branch. - These people had the same problem/solution: reflex-dev/reflex#1558
Describe the bug
A clear and concise description of what the bug is.
The image and gif files shown on PyPI need to be corrected.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Specifics (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: