-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown Images are not rendered in pypi #5246
Comments
The issue appears to be that the URLs used for the links target a GitHub page, not an image directly. I loaded the README.md into Macdown on my computer locally and can reproduce. If you navigate to https://github.com/kirankotari/shconfparser/blob/master/asserts/img/sh_run.png in a browser you'll see that a UI appears, not the image itself. GitHub seems to be handling this seamlessly. You could use the raw URL instead as a workaround, https://github.com/kirankotari/shconfparser/raw/master/asserts/img/sh_run.png PyPI does not support rendering from the package path itself, as it is not an image host. I'm not sure if there is a reasonable approach to automatically handling either case. |
Thanks @ewdurbin |
According to this issue pypi/warehouse#5246, that seems to be the official solution. (I.e, PyPI will NOT read images from the package.)
Hello, we have some problem with rendering GitHub status badges - https://pypi.org/project/pytorch-lightning/1.0.8/ |
Hi @Borda - many users upload images to GitHub or another image hosting service (like imgur) or host the images on their own domain. PyPI will link directly to the image, so if the hosted image is changed or removed, it will change on PyPI as well. |
PyPI needs a link to properly render the logo xref pypi/warehouse#5246
PyPI needs a link to properly render the logo xref pypi/warehouse#5246
Describe the bug
Images are not rendered in pypi from README.md file
Package link: https://pypi.org/project/shconfparser
Image Size:
sh_cdp_neighbour.png - 184 KB
sh_run.png - 855 KB
Expected behavior
Images need to be rendered, as shown in the following link
Github link: https://github.com/kirankotari/shconfparser
To Reproduce
Image from a link:
![show run to tree structure](https://github.com/kirankotari/shconfparser/blob/master/asserts/img/sh_run.png)
Testing using image from package path:
![show run to tree structure](/asserts/img/sh_run.png)
My Platform
Checked in Chrome 71 and IE 11
Additional context
The warehouse image link says
Not Found
The text was updated successfully, but these errors were encountered: