[docs] Fix missing images on PyPI page #19028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
alangenfeld
approved these changes
Jan 4, 2024
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jan 6, 2024
## Summary & Motivation Currently there are several images missing on our PyPI page:  The PyPI page is derived from the Dagster README, which gets copied into the `long_description` field of the PyPI package. `img` elements in the README with relative URLs then can't be resolved. This PR replaces the all relative URLs in `img` tags with full URLs to github master. ## How I Tested These Changes Not sure how to directly test PyPI without releasing, but: - You can see the README still renders on this branch. - These people had the same problem/solution: reflex-dev/reflex#1558
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Currently there are several images missing on our PyPI page:
The PyPI page is derived from the Dagster README, which gets copied into the
long_descriptionfield of the PyPI package.imgelements in the README with relative URLs then can't be resolved.This PR replaces the all relative URLs in
imgtags with full URLs to github master.How I Tested These Changes
Not sure how to directly test PyPI without releasing, but: