Improve Gist detection; exclude Gist profiles from isProfile
#132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for preview-for-github-url-detection ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Closed
fregante
commented
Jul 23, 2022
| ]); | ||
|
|
||
| export const isGist = (url: URL | HTMLAnchorElement | Location = location): boolean => url.hostname.startsWith('gist.') || url.pathname.split('/', 2)[1] === 'gist'; | ||
| export const isGist = (url: URL | HTMLAnchorElement | Location = location): boolean => typeof getCleanGistPathname(url) === 'string'; |
There was a problem hiding this comment.
This test was incorrect. It would match gist.any.com while in reality GHE probably only supports /gist/
There was a problem hiding this comment.
I remember we had a link to a github enterprise that we were able to test things out.
There was a problem hiding this comment.
I was wrong:
http(s)://[hostname]/gistorhttp(s)://gist.[hostname]if subdomains are enabled.
package.json
Outdated
| @@ -34,6 +34,7 @@ | |||
| "test": "run-p build ava xo", | |||
| "watch": "run-p watch:typescript demo:watch # vite watch doesn’t generate the lib, so just use the demo", | |||
| "watch:typescript": "tsc --watch --noEmit", | |||
| "watch:ava": "run-p ava watch:typescript -- --watch", | |||
There was a problem hiding this comment.
AVA times out when there are certain type errors 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isProfilesupposed to include gist profiles? #117isSingleGistis too broad and incorrect #80