Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calls for major release #133

Closed
fregante opened this issue Jul 23, 2022 · 7 comments · Fixed by #144
Closed

Calls for major release #133

fregante opened this issue Jul 23, 2022 · 7 comments · Fixed by #144
Assignees
Labels

Comments

@kidonng
Copy link
Member

kidonng commented Jul 23, 2022

Good timing! Just recently I want to add "organization level discussions" (example: https://github.com/orgs/github-community/discussions), this is how GitHub calls it:

image

But we already have a isOrganizationDiscussion, which would be better named isTeamDiscussion?

@yakov116
Copy link
Member

Drop depreciated
Maybe visit the conversation issue?

@fregante
Copy link
Member Author

Are you talking about “conversations === issues and PRs”? We can’t change here, it’s a user-facing issue

Or isConversation vs isConversationList?

@yakov116
Copy link
Member

Is conversation list

@fregante
Copy link
Member Author

Time to switch to isIssueOrPRList, etc

@fregante
Copy link
Member Author

@kidonng mind sending a PR?

@fregante
Copy link
Member Author

That's a lot of breaking changed 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

4 participants