Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is isProfile supposed to include gist profiles? #117

Closed
yakov116 opened this issue Mar 28, 2022 · 1 comment · Fixed by #132
Closed

Is isProfile supposed to include gist profiles? #117

yakov116 opened this issue Mar 28, 2022 · 1 comment · Fixed by #132

Comments

@yakov116
Copy link
Member

yakov116 commented Mar 28, 2022

export const isProfile = (url: URL | HTMLAnchorElement | Location = location): boolean => {
const pathname = getCleanPathname(url);
return pathname.length > 0 && !pathname.includes('/') && !pathname.includes('.') && !reservedNames.includes(pathname);
};

I am getting an error in RGH
profile-gists-link and show-user-top-repositories due to isProfile working on gists.
https://gist.github.com/yakov116

@fregante
Copy link
Member

I don’t think it should be. While the UI is similar, if I specify "isProfile" I wouldn't think of looking at gist. In my mind it's an entirely different site. I'd rather exclude it from isProfile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants