Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial: Use curly braces and return in ArticleCell Success #6224

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Aug 17, 2022

Fixes #6205 #6214

The scaffold generator produces cell components that use curly braces and a return statement. This PR updates the code snippet in the tutorial to match.

@nx-cloud
Copy link

nx-cloud bot commented Aug 17, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6471cd6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 14 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Aug 17, 2022

Deploy Preview for redwoodjs-docs ready!

Name Link
🔨 Latest commit 6471cd6
🔍 Latest deploy log https://app.netlify.com/sites/redwoodjs-docs/deploys/62fdcdd569c94c0009b97f11
😎 Deploy Preview https://deploy-preview-6224--redwoodjs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Tobbe Tobbe added the release:docs This PR only updates docs label Aug 17, 2022
@Tobbe Tobbe requested a review from cannikin August 17, 2022 00:36
@Tobbe Tobbe force-pushed the tobbe-tutorial-curly-braces branch from 1ef1dcb to 8eeaba9 Compare August 18, 2022 05:27
@Tobbe Tobbe enabled auto-merge (squash) August 18, 2022 05:28
@Tobbe Tobbe merged commit a54f9ee into redwoodjs:main Aug 18, 2022
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Aug 18, 2022
// highlight-next-line
<Article article={article} />
)
return <Article article={article} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tobbe What about lines 764 & 766?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bah. JS. Who even cares? 😜
Just kidding. Of course those should be updated too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

@Tobbe Tobbe Aug 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:docs This PR only updates docs
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants