-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
return for proper rendering #6205
Conversation
works with return, don't know if adding <> </> would be better.
☁️ Nx Cloud ReportWe didn't find any information for the current pull request with the commit 6cca26c. Check the Nx Cloud Github Integration documentation for more information. Sent with 💌 from NxCloud. |
✅ Deploy Preview for redwoodjs-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This is the same as #6214 I closed that one, because the syntax is valid. But now I'm starting to doubt myself. Why do we get two PRs for the exact same thing so close to each other? Is something confusing here that we need to change? |
I was working through your tutorial and I was getting a 'render error'. Adding the return to this component fixed the issue. I'm not an expert on react but I'm wondering if it has to do with scoping of the parent components. |
Can you share a screenshot of the error in your editor please? |
It's super weird, because the change you've suggested is a syntax error. It would have to be curly braces, not regular parentheses for the |
To make this less confusing I think we should keep the curly braces from the first code block in the second as well. And add the |
Thank you! Just as I expected, you had the curly braces I can totally see how this is all super confusing. Sorry! |
This is what was there following the tutorial. **I see it is the difference between '{' and '('. I'll make the change. I didn't see the difference in the doc. I was just looking at the highlighted line ** |
going to close and let the rw team address the docs. |
I made a PR that changes to |
works with return, don't know if adding <> </> would be better.