Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial: Use curly braces and return in ArticleCell Success #6224

Merged
merged 2 commits into from
Aug 18, 2022
Merged

Tutorial: Use curly braces and return in ArticleCell Success #6224

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8eeaba9
Curly braces and return
Tobbe Aug 17, 2022
6471cd6
Merge branch 'main' into tobbe-tutorial-curly-braces
Tobbe Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/docs/tutorial/chapter2/routing-params.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,10 +796,10 @@ export const Failure = ({ error }: CellFailureProps) => (
<div style={{ color: 'red' }}>Error: {error.message}</div>
)

export const Success = ({ article }: CellSuccessProps<ArticleQuery>) => (
export const Success = ({ article }: CellSuccessProps<ArticleQuery>) => {
// highlight-next-line
<Article article={article} />
)
return <Article article={article} />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tobbe What about lines 764 & 766?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bah. JS. Who even cares? 😜
Just kidding. Of course those should be updated too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6235

Copy link
Member Author

@Tobbe Tobbe Aug 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Philzen #6235

}
```

</TabItem>
Expand Down