Cherry pick improvements from helm charts repo #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Deployment Spec token auto mount takes precendese over Service Account token auto mount. Now both token auto mount properties should be set to true in order to not mount volume. Reference redpanda-data/helm-charts@5d1314e
…within same PR Reference redpanda-data/helm-charts@cc5a36d
Prior to this commit objects produced from the console helm chart would inconsistently set `namespace`. This isn't particularly noticeable as `kubectl` and `helm` often set namespace transparently but it can cause issues when using other tooling. This commit sets namespace on all objects it was set on, adds a test assertion that namespace is present across all objects, and removes usages of `extraInitContainers` from tests as they generated invalid manifests. Reference redpanda-data/helm-charts@592a079
The operator pprof port 8082 conflicts with Redpanda HTTP port. https://github.com/redpanda-data/helm-charts/blob/5d1314e014382f1354e9b08324ebb2cc20f47840/charts/redpanda/values.yaml#L956 Reference redpanda-data/helm-charts@b0a8f61
Set default value for tiered storage cache to `none` which will defer tiered storage cache path to Redpanda process. Previously the `emptyDir` volume could fill Kubernetes VM quickly and tip over such K8S Node. Then user would need to restart Pod to clean the content of the `emptyDir` volume. Reference redpanda-data/helm-charts@78a4c0b
RafalKorepta
requested review from
chrisseto and
andrewstucki
as code owners
andrewstucki
approved these changes
Dec 18, 2024
RafalKorepta
force-pushed
the
rk/cherry-pick-some-improvements-from-helm-charts-repo
branch
from
dfd90ab to
dedb1e4
Compare
|
Heads up, but I manually ran |
andrewstucki
force-pushed
the
rk/cherry-pick-some-improvements-from-helm-charts-repo
branch
from
d96888f to
4620e61
Compare
andrewstucki
deleted the
rk/cherry-pick-some-improvements-from-helm-charts-repo
branch
RafalKorepta
added a commit
to redpanda-data/helm-charts
that referenced
this pull request
Jan 8, 2025
The source of truth is now redpanda-operator repostiory where gotohelm, genpartial and genschema cli are located. Those tools will generate inside redpanda-operator repository the following charts: * connectors * console * operator * redpanda Reference redpanda-data/redpanda-operator#339 redpanda-data/redpanda-operator#354 redpanda-data/redpanda-operator#365
RafalKorepta
added a commit
to redpanda-data/helm-charts
that referenced
this pull request
Jan 8, 2025
The source of truth is now redpanda-operator repostiory where gotohelm, genpartial and genschema cli are located. Those tools will generate inside redpanda-operator repository the following charts: * connectors * console * operator * redpanda Reference redpanda-data/redpanda-operator#339 redpanda-data/redpanda-operator#354 redpanda-data/redpanda-operator#365
RafalKorepta
added a commit
to redpanda-data/helm-charts
that referenced
this pull request
Jan 8, 2025
The source of truth is now redpanda-operator repostiory where gotohelm, genpartial and genschema cli are located. Those tools will generate inside redpanda-operator repository the following charts: * connectors * console * operator * redpanda Reference redpanda-data/redpanda-operator#339 redpanda-data/redpanda-operator#354 redpanda-data/redpanda-operator#365
RafalKorepta
added a commit
to redpanda-data/helm-charts
that referenced
this pull request
Jan 8, 2025
The source of truth is now redpanda-operator repostiory where gotohelm, genpartial and genschema cli are located. Those tools will generate inside redpanda-operator repository the following charts: * connectors * console * operator * redpanda Reference redpanda-data/redpanda-operator#339 redpanda-data/redpanda-operator#354 redpanda-data/redpanda-operator#365
RafalKorepta
added a commit
to redpanda-data/helm-charts
that referenced
this pull request
Jan 8, 2025
The source of truth is now redpanda-operator repostiory where gotohelm, genpartial and genschema cli are located. Those tools will generate inside redpanda-operator repository the following charts: * connectors * console * operator * redpanda Reference redpanda-data/redpanda-operator#339 redpanda-data/redpanda-operator#354 redpanda-data/redpanda-operator#365
RafalKorepta
added a commit
to redpanda-data/helm-charts
that referenced
this pull request
Jan 8, 2025
The source of truth is now redpanda-operator repostiory where gotohelm, genpartial and genschema cli are located. Those tools will generate inside redpanda-operator repository the following charts: * connectors * console * operator * redpanda Reference redpanda-data/redpanda-operator#339 redpanda-data/redpanda-operator#354 redpanda-data/redpanda-operator#365
RafalKorepta
added a commit
to redpanda-data/helm-charts
that referenced
this pull request
Jan 8, 2025
The source of truth is now redpanda-operator repostiory where gotohelm, genpartial and genschema cli are located. Those tools will generate inside redpanda-operator repository the following charts: * connectors * console * operator * redpanda Reference redpanda-data/redpanda-operator#339 redpanda-data/redpanda-operator#354 redpanda-data/redpanda-operator#365
RafalKorepta
added a commit
to redpanda-data/helm-charts
that referenced
this pull request
Jan 8, 2025
The source of truth is now redpanda-operator repostiory where gotohelm, genpartial and genschema cli are located. Those tools will generate inside redpanda-operator repository the following charts: * connectors * console * operator * redpanda Reference redpanda-data/redpanda-operator#339 redpanda-data/redpanda-operator#354 redpanda-data/redpanda-operator#365
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of PRs included
.Namespacehelm-charts#1586nonehelm-charts#1625