Handle Service Account auto mount with Deployment Spec token auto mount #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafalKorepta
force-pushed
the
rk/k8s-431/auto-mount-property
branch
2 times, most recently
from
198b5d8 to
f59aae6
Compare
RafalKorepta
changed the title
|
A bit confused about what's being fixed and why it's being fixed this way. Could we not ignore these options and instead always include the service account token mounts / volumes? |
RafalKorepta
force-pushed
the
rk/k8s-431/auto-mount-property
branch
from
f59aae6 to
c32a9f4
Compare
You are right. I will just mount service account token, but only when service account is created. If user would like to disable Service Account, then PodTemplate would need to be used to mount service account token with service account name. |
The Deployment Spec token auto mount takes precendese over Service Account token auto mount. Now both token auto mount properties should be set to true in order to not mount volume.
RafalKorepta
force-pushed
the
rk/k8s-431/auto-mount-property
branch
from
c32a9f4 to
a4535e2
Compare
chrisseto
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Deployment Spec token auto mount takes precendese over Service Account token
auto mount. Now both token auto mount properties should be set to true in order
to not mount volume.