Change tiered storage cache setting to none
#1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafalKorepta
requested review from
JakeSCahill,
chrisseto and
andrewstucki
as code owners
andrewstucki
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
I'm generally fine with this, can we double check/verify manually though what this looks like when we move from emptyDir to none in a release though? Just wanting to make sure nothing wonky happens/we aren't likely to break folks by switching this default on an existing installation.
It should be checked by our e2e tests (chart testing). |
Set default value for tiered storage cache to `none` which will defer tiered storage cache path to Redpanda process. Previously the `emptyDir` volume could fill Kubernetes VM quickly and tip over such K8S Node. Then user would need to restart Pod to clean the content of the `emptyDir` volume.
RafalKorepta
force-pushed
the
rk/k8s-147/change-tiered-storage-default
branch
from
fe266fa to
c0ff594
Compare
chrisseto
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set default value for tiered storage cache to
nonewhich will defer tieredstorage cache path to Redpanda process. Previously the
emptyDirvolume couldfill Kubernetes VM quickly and tip over such K8S Node. Then user would need to
restart Pod to clean the content of the
emptyDirvolume.K8S-147
Fixes #1176