Skip to content

Commit

Permalink
Change tiered storage cache default to none
Browse files Browse the repository at this point in the history
Set default value for tiered storage cache to `none` which will defer tiered
storage cache path to Redpanda process. Previously the `emptyDir` volume could
fill Kubernetes VM quickly and tip over such K8S Node. Then user would need to
restart Pod to clean the content of the `emptyDir` volume.
  • Loading branch information
RafalKorepta committed Dec 18, 2024
1 parent 5229fef commit 78a4c0b
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 30 deletions.
2 changes: 1 addition & 1 deletion charts/redpanda/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1034,7 +1034,7 @@ Persistence settings. For details, see the [storage documentation](https://docs.
**Default:**

```
{"hostPath":"","persistentVolume":{"annotations":{},"enabled":true,"labels":{},"nameOverwrite":"","size":"20Gi","storageClass":""},"tiered":{"config":{"cloud_storage_cache_size":5368709120,"cloud_storage_enable_remote_read":true,"cloud_storage_enable_remote_write":true,"cloud_storage_enabled":false},"credentialsSecretRef":{"accessKey":{"configurationKey":"cloud_storage_access_key"},"secretKey":{"configurationKey":"cloud_storage_secret_key"}},"hostPath":"","mountType":"emptyDir","persistentVolume":{"annotations":{},"labels":{},"storageClass":""}}}
{"hostPath":"","persistentVolume":{"annotations":{},"enabled":true,"labels":{},"nameOverwrite":"","size":"20Gi","storageClass":""},"tiered":{"config":{"cloud_storage_cache_size":5368709120,"cloud_storage_enable_remote_read":true,"cloud_storage_enable_remote_write":true,"cloud_storage_enabled":false},"credentialsSecretRef":{"accessKey":{"configurationKey":"cloud_storage_access_key"},"secretKey":{"configurationKey":"cloud_storage_secret_key"}},"hostPath":"","mountType":"none","persistentVolume":{"annotations":{},"labels":{},"storageClass":""}}}
```

### [storage.hostPath](https://artifacthub.io/packages/helm/redpanda-data/redpanda?modal=values&path=storage.hostPath)
Expand Down
28 changes: 0 additions & 28 deletions charts/redpanda/testdata/template-cases.golden.txtar
Original file line number Diff line number Diff line change
Expand Up @@ -25980,8 +25980,6 @@ spec:
name: lifecycle-scripts
- mountPath: /var/lib/redpanda/data
name: datadir
- mountPath: /var/lib/redpanda/data/cloud_storage_cache
name: tiered-storage-dir
- args:
- -c
- trap "exit 0" TERM; exec /etc/secrets/config-watcher/scripts/sasl-user.sh
Expand Down Expand Up @@ -26040,8 +26038,6 @@ spec:
name: redpanda-external-cert
- mountPath: /var/lib/redpanda/data
name: datadir
- mountPath: /var/lib/redpanda/data/cloud_storage_cache
name: tiered-storage-dir
- command:
- /bin/bash
- -c
Expand Down Expand Up @@ -26156,9 +26152,6 @@ spec:
- name: datadir
persistentVolumeClaim:
claimName: datadir
- emptyDir:
sizeLimit: 5368709120
name: tiered-storage-dir
updateStrategy:
type: RollingUpdate
volumeClaimTemplates:
Expand Down Expand Up @@ -27438,8 +27431,6 @@ spec:
name: lifecycle-scripts
- mountPath: /var/lib/redpanda/data
name: datadir
- mountPath: /var/lib/redpanda/data/cloud_storage_cache
name: tiered-storage-dir
- args:
- -c
- trap "exit 0" TERM; exec /etc/secrets/config-watcher/scripts/sasl-user.sh
Expand Down Expand Up @@ -27498,8 +27489,6 @@ spec:
name: redpanda-external-cert
- mountPath: /var/lib/redpanda/data
name: datadir
- mountPath: /var/lib/redpanda/data/cloud_storage_cache
name: tiered-storage-dir
- command:
- /bin/bash
- -c
Expand Down Expand Up @@ -27614,9 +27603,6 @@ spec:
- name: datadir
persistentVolumeClaim:
claimName: datadir
- emptyDir:
sizeLimit: 5368709120
name: tiered-storage-dir
updateStrategy:
type: RollingUpdate
volumeClaimTemplates:
Expand Down Expand Up @@ -28894,8 +28880,6 @@ spec:
name: lifecycle-scripts
- mountPath: /var/lib/redpanda/data
name: datadir
- mountPath: /var/lib/redpanda/data/cloud_storage_cache
name: tiered-storage-dir
- args:
- -c
- trap "exit 0" TERM; exec /etc/secrets/config-watcher/scripts/sasl-user.sh
Expand Down Expand Up @@ -28954,8 +28938,6 @@ spec:
name: redpanda-external-cert
- mountPath: /var/lib/redpanda/data
name: datadir
- mountPath: /var/lib/redpanda/data/cloud_storage_cache
name: tiered-storage-dir
- command:
- /bin/bash
- -c
Expand Down Expand Up @@ -29070,9 +29052,6 @@ spec:
- name: datadir
persistentVolumeClaim:
claimName: datadir
- emptyDir:
sizeLimit: 5368709120
name: tiered-storage-dir
updateStrategy:
type: RollingUpdate
volumeClaimTemplates:
Expand Down Expand Up @@ -30297,8 +30276,6 @@ spec:
name: lifecycle-scripts
- mountPath: /var/lib/redpanda/data
name: datadir
- mountPath: /var/lib/redpanda/data/cloud_storage_cache
name: tiered-storage-dir
- args:
- -c
- trap "exit 0" TERM; exec /etc/secrets/config-watcher/scripts/sasl-user.sh
Expand Down Expand Up @@ -30357,8 +30334,6 @@ spec:
name: redpanda-external-cert
- mountPath: /var/lib/redpanda/data
name: datadir
- mountPath: /var/lib/redpanda/data/cloud_storage_cache
name: tiered-storage-dir
- command:
- /bin/bash
- -c
Expand Down Expand Up @@ -30473,9 +30448,6 @@ spec:
- name: datadir
persistentVolumeClaim:
claimName: datadir
- emptyDir:
sizeLimit: 5368709120
name: tiered-storage-dir
updateStrategy:
type: RollingUpdate
volumeClaimTemplates:
Expand Down
2 changes: 1 addition & 1 deletion charts/redpanda/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ storage:
# - hostPath: will allow you to chose a path on the Node the pod is running on
# - emptyDir: will mount a fresh empty directory every time the pod starts
# - persistentVolume: creates and mounts a PersistentVolumeClaim
mountType: emptyDir
mountType: none

# For the maximum size of the disk cache, see `tieredConfig.cloud_storage_cache_size`.
#
Expand Down

0 comments on commit 78a4c0b

Please sign in to comment.