Mark issues and pull requests as stale #6872

ritudes · 2023-06-07T08:34:01Z

What type of PR is this:

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6610

PR acceptance criteria:

Unit test
Integration test
Documentation

How to test changes / Special notes to the reviewer:

Signed-off-by: Ritu Deshmukh <[email protected]>

netlify · 2023-06-07T08:34:05Z

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name	Link
🔨 Latest commit	`d376218`
🔍 Latest deploy log	https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64830be53691410008410bb8

odo-robot · 2023-06-07T08:40:46Z

OpenShift Unauthenticated Tests on commit daf1e6c finished successfully.
View logs: TXT HTML

odo-robot · 2023-06-07T08:41:08Z

NoCluster Tests on commit daf1e6c finished successfully.
View logs: TXT HTML

odo-robot · 2023-06-07T08:43:29Z

Unit Tests on commit daf1e6c finished successfully.
View logs: TXT HTML

odo-robot · 2023-06-07T08:48:52Z

Validate Tests on commit daf1e6c finished successfully.
View logs: TXT HTML

odo-robot · 2023-06-07T09:04:03Z

Kubernetes Tests on commit daf1e6c finished successfully.
View logs: TXT HTML

odo-robot · 2023-06-07T09:04:42Z

Windows Tests (OCP) on commit finished with errors.
View logs: TXT HTML

odo-robot · 2023-06-07T09:15:03Z

Kubernetes Docs Tests on commit 029c538 finished with errors.
View logs: TXT HTML

odo-robot · 2023-06-07T09:32:46Z

OpenShift Tests on commit daf1e6c finished with errors.
View logs: TXT HTML

rm3l

Added a few suggestions:

Changed the number of days before marking an issue/PR as stale, and before closing it. Based on what I can see from old issues like this one, issues were marked as stale after 90 days of inactivity, and rotten/closed after an additional 30d of inactivity. I think this makes better sense.
Leverage the lifecycle/* labels we already have: https://github.com/redhat-developer/odo/labels?q=lifecycle
- This is useful in certain cases to exempt issues with certain labels from this action, for example, if they are explicitly labeled as active or frozen.
More details in the stale message about when the issue will be closed

.github/workflows/stale.yaml

Co-authored-by: Armel Soro <[email protected]>

sonarqubecloud · 2023-06-09T11:24:49Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

sonarqubecloud · 2023-06-09T11:24:53Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

ritudes · 2023-06-09T11:25:51Z

Thank you for your reviews @rm3l .I have applied those changes as per your suggestions

rm3l · 2023-06-09T15:43:03Z

  [FAILED] registry_list_output.mdx
  Expected
      <string>:   strings.Join({
        	... // 108 identical bytes
        	"                        VERSIONS\nnodejs-react  StagingRegistry  ",
        	"       React is a free and open-source front-en...  2.0.2, 2.1.0",
      + 	", 2.2.0",
        	"\nnodejs-react  DefaultDevfileRegistry  React is a free and open-",
        	"source front-en...  2.0.2, 2.1.0\n```\n",
        }, "")
      
  to be empty
  In [It] at: /go/odo_1/tests/documentation/command-reference/doc_command_reference_init_test.go:189 @ 06/09/23 12:49:03.116
------------------------------
â€¢â€¢â€¢â€¢â€¢â€¢Spawning '/go/bin/odo init' from /tmp/591808707
â€¢â€¢â€¢Spawning '/go/bin/odo delete project odo-dev' from /tmp/2208322380
â€¢â€¢â€¢â€¢

Summarizing 1 Failure:
  [FAIL] doc command reference odo init Non Interactive Mode fetching devfile from a registry when setting up the registry [It] Fetch Devfile from any registry of the list [nocluster]
  /go/odo_1/tests/documentation/command-reference/doc_command_reference_init_test.go:189

Ran 16 of 16 Specs in 46.762 seconds
FAIL! -- 15 Passed | 1 Failed | 0 Pending | 0 Skipped

Reported in #6876

/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

openshift-ci · 2023-06-09T15:43:08Z

@rm3l: Overrode contexts on behalf of rm3l: Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

In response to this:

 [FAILED] registry_list_output.mdx
 Expected
     <string>:   strings.Join({
       	... // 108 identical bytes
       	"                        VERSIONS\nnodejs-react  StagingRegistry  ",
       	"       React is a free and open-source front-en...  2.0.2, 2.1.0",
     + 	", 2.2.0",
       	"\nnodejs-react  DefaultDevfileRegistry  React is a free and open-",
       	"source front-en...  2.0.2, 2.1.0\n```\n",
       }, "")
     
 to be empty
 In [It] at: /go/odo_1/tests/documentation/command-reference/doc_command_reference_init_test.go:189 @ 06/09/23 12:49:03.116
------------------------------
â€¢â€¢â€¢â€¢â€¢â€¢Spawning '/go/bin/odo init' from /tmp/591808707
â€¢â€¢â€¢Spawning '/go/bin/odo delete project odo-dev' from /tmp/2208322380
â€¢â€¢â€¢â€¢

Summarizing 1 Failure:
 [FAIL] doc command reference odo init Non Interactive Mode fetching devfile from a registry when setting up the registry [It] Fetch Devfile from any registry of the list [nocluster]
 /go/odo_1/tests/documentation/command-reference/doc_command_reference_init_test.go:189

Ran 16 of 16 Specs in 46.762 seconds
FAIL! -- 15 Passed | 1 Failed | 0 Pending | 0 Skipped

Reported in #6876

/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rm3l · 2023-06-09T15:46:21Z

...
 [odo]  âš   AttachVolume.Attach failed for volume "pvc-76ffbf80-442b-4a64-825b-8b931bde3264" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-796cee09-5495-42c5-9c28-f0c09c729b4a
  [odo]  âš   Unable to attach or mount volumes: unmounted volumes=[odo-projects], unattached volumes=[odo-projects odo-shared-data kube-api-access-5hsp9]: timed out waiting for the condition
  [FAILED] in [BeforeEach] - /go/odo_1/tests/helper/helper_run.go:54 @ 06/09/23 12:33:41.225
  Deleting project: cmd-dev-test468xck
...
  [odo]  âš   AttachVolume.Attach failed for volume "pvc-dbbed17f-7a30-40d4-b0a5-ac4470f8ae04" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-e0f0bcbe-af9b-45ae-8a75-4ecf629092ef
  [odo]  âš   AttachVolume.Attach failed for volume "pvc-a48b435e-ac81-498e-9cd1-fdc4f9e6b79a" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-61568a66-adc6-417b-89d0-d0bc25dc8449
  [odo]  âš   Unable to attach or mount volumes: unmounted volumes=[firstvol-araele-app-vol secondvol-araele-app-vol], unattached volumes=[odo-projects odo-shared-data firstvol-araele-app-vol secondvol-araele-app-vol kube-api-access-jj9qx]: timed out waiting for the condition
...

Summarizing 2 Failures:
  [FAIL] odo dev command tests when running odo dev with devfile containing volume-component - without metadata.name [BeforeEach] should successfully use the volume components in container components
  /go/odo_1/tests/helper/helper_run.go:54
  [FAIL] odo dev command tests when a component is bootstrapped when odo dev is executed and Ephemeral is set to false [BeforeEach] when killing odo dev and running odo delete component --wait should have deleted all resources before returning
  /go/odo_1/tests/helper/helper_run.go:54

Ran 489 of 932 Specs in 1569.096 seconds
FAIL! -- 487 Passed | 2 Failed | 0 Pending | 443 Skipped

Issues with attaching volumes on OpenShift.
Overriding because the changes here are only about adding a new GitHub Workflow for housekeeping..

/override OpenShift-Integration-tests/OpenShift-Integration-tests

openshift-ci · 2023-06-09T15:46:25Z

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

...
[odo]  âš   AttachVolume.Attach failed for volume "pvc-76ffbf80-442b-4a64-825b-8b931bde3264" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-796cee09-5495-42c5-9c28-f0c09c729b4a
 [odo]  âš   Unable to attach or mount volumes: unmounted volumes=[odo-projects], unattached volumes=[odo-projects odo-shared-data kube-api-access-5hsp9]: timed out waiting for the condition
 [FAILED] in [BeforeEach] - /go/odo_1/tests/helper/helper_run.go:54 @ 06/09/23 12:33:41.225
 Deleting project: cmd-dev-test468xck
...
 [odo]  âš   AttachVolume.Attach failed for volume "pvc-dbbed17f-7a30-40d4-b0a5-ac4470f8ae04" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-e0f0bcbe-af9b-45ae-8a75-4ecf629092ef
 [odo]  âš   AttachVolume.Attach failed for volume "pvc-a48b435e-ac81-498e-9cd1-fdc4f9e6b79a" : timed out waiting for external-attacher of vpc.block.csi.ibm.io CSI driver to attach volume r010-61568a66-adc6-417b-89d0-d0bc25dc8449
 [odo]  âš   Unable to attach or mount volumes: unmounted volumes=[firstvol-araele-app-vol secondvol-araele-app-vol], unattached volumes=[odo-projects odo-shared-data firstvol-araele-app-vol secondvol-araele-app-vol kube-api-access-jj9qx]: timed out waiting for the condition
...

Summarizing 2 Failures:
 [FAIL] odo dev command tests when running odo dev with devfile containing volume-component - without metadata.name [BeforeEach] should successfully use the volume components in container components
 /go/odo_1/tests/helper/helper_run.go:54
 [FAIL] odo dev command tests when a component is bootstrapped when odo dev is executed and Ephemeral is set to false [BeforeEach] when killing odo dev and running odo delete component --wait should have deleted all resources before returning
 /go/odo_1/tests/helper/helper_run.go:54

Ran 489 of 932 Specs in 1569.096 seconds
FAIL! -- 487 Passed | 2 Failed | 0 Pending | 443 Skipped

Issues with attaching volumes on OpenShift.
Overriding because the changes here are only about adding a new GitHub Workflow for housekeeping..

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Mark issues and pull requests as stale

1bb4c54

Signed-off-by: Ritu Deshmukh <[email protected]>

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 7, 2023

openshift-ci bot requested review from anandrkskd and kadel June 7, 2023 08:34

ritudes requested a review from rm3l June 7, 2023 08:34

rm3l requested changes Jun 9, 2023

View reviewed changes

openshift-ci bot assigned rm3l Jun 9, 2023

ritudes and others added 7 commits June 9, 2023 16:52

Update .github/workflows/stale.yaml

7a2d714

Co-authored-by: Armel Soro <[email protected]>

Update .github/workflows/stale.yaml

b613a25

Co-authored-by: Armel Soro <[email protected]>

Update .github/workflows/stale.yaml

84fc074

Co-authored-by: Armel Soro <[email protected]>

Update .github/workflows/stale.yaml

db32442

Co-authored-by: Armel Soro <[email protected]>

Update .github/workflows/stale.yaml

4488756

Co-authored-by: Armel Soro <[email protected]>

Update .github/workflows/stale.yaml

981b795

Co-authored-by: Armel Soro <[email protected]>

Update .github/workflows/stale.yaml

d376218

Co-authored-by: Armel Soro <[email protected]>

rm3l approved these changes Jun 9, 2023

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 9, 2023

rm3l changed the title ~~[WIP]Mark issues and pull requests as stale~~ Mark issues and pull requests as stale Jun 9, 2023

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 9, 2023

rm3l mentioned this pull request Jun 9, 2023

Doc automation tests broken due to new NodeJS Stacks versions in staging registry #6876

Closed

openshift-merge-robot merged commit d892e8e into redhat-developer:main Jun 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mark issues and pull requests as stale #6872

Mark issues and pull requests as stale #6872

ritudes commented Jun 7, 2023

netlify bot commented Jun 7, 2023 •

edited

Loading

odo-robot bot commented Jun 7, 2023 •

edited

Loading

odo-robot bot commented Jun 7, 2023 •

edited

Loading

odo-robot bot commented Jun 7, 2023 •

edited

Loading

odo-robot bot commented Jun 7, 2023 •

edited

Loading

odo-robot bot commented Jun 7, 2023 •

edited

Loading

odo-robot bot commented Jun 7, 2023

odo-robot bot commented Jun 7, 2023 •

edited

Loading

odo-robot bot commented Jun 7, 2023 •

edited

Loading

rm3l left a comment

sonarqubecloud bot commented Jun 9, 2023

sonarqubecloud bot commented Jun 9, 2023

ritudes commented Jun 9, 2023

rm3l commented Jun 9, 2023

openshift-ci bot commented Jun 9, 2023

rm3l commented Jun 9, 2023

openshift-ci bot commented Jun 9, 2023

Mark issues and pull requests as stale #6872

Mark issues and pull requests as stale #6872

Conversation

ritudes commented Jun 7, 2023

netlify bot commented Jun 7, 2023 • edited Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

odo-robot bot commented Jun 7, 2023 • edited Loading

odo-robot bot commented Jun 7, 2023 • edited Loading

odo-robot bot commented Jun 7, 2023 • edited Loading

odo-robot bot commented Jun 7, 2023 • edited Loading

odo-robot bot commented Jun 7, 2023 • edited Loading

odo-robot bot commented Jun 7, 2023

odo-robot bot commented Jun 7, 2023 • edited Loading

odo-robot bot commented Jun 7, 2023 • edited Loading

rm3l left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jun 9, 2023

sonarqubecloud bot commented Jun 9, 2023

ritudes commented Jun 9, 2023

rm3l commented Jun 9, 2023

openshift-ci bot commented Jun 9, 2023

rm3l commented Jun 9, 2023

openshift-ci bot commented Jun 9, 2023

netlify bot commented Jun 7, 2023 •

edited

Loading

odo-robot bot commented Jun 7, 2023 •

edited

Loading

odo-robot bot commented Jun 7, 2023 •

edited

Loading

odo-robot bot commented Jun 7, 2023 •

edited

Loading

odo-robot bot commented Jun 7, 2023 •

edited

Loading

odo-robot bot commented Jun 7, 2023 •

edited

Loading

odo-robot bot commented Jun 7, 2023 •

edited

Loading

odo-robot bot commented Jun 7, 2023 •

edited

Loading