-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: #227: scaffolder option no redux #268
chore: #227: scaffolder option no redux #268
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am approving because I don't want to block you but please remove the debugger before merging. Nice work 👍
|
||
if (refreshParams && !hasSession) { | ||
setRefreshSession(refreshParams) | ||
return null | ||
} | ||
|
||
if (!hasSession) { | ||
debugger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debugger left in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bdb4bc4
to
6874063
Compare
* temp * temp * chore: #33 update marketplace-api-schema.ts file * chore: #230 Update scaffolder styles solutions (#259) * temp * temp * chore: #230 Update scaffolder styles solutions * chore: #230 Update .gitignore * chore: #230 update types file Co-authored-by: NghiaPham <[email protected]> * chore: #227: scaffolder option no redux (#268) * chore: #244 Update base files of the scaffolder * fix .gitignore * update schema file * update snapshot Co-authored-by: Khac Vy <[email protected]> Co-authored-by: Dan Nguyen <[email protected]>
* temp * temp * chore: #33 update marketplace-api-schema.ts file * chore: #230 Update scaffolder styles solutions (#259) * temp * temp * chore: #230 Update scaffolder styles solutions * chore: #230 Update .gitignore * chore: #230 update types file Co-authored-by: NghiaPham <[email protected]> * chore: #227: scaffolder option no redux (#268) * chore: #244 Update base files of the scaffolder * fix .gitignore * update schema file * update snapshot Co-authored-by: Khac Vy <[email protected]> Co-authored-by: Dan Nguyen <[email protected]>
No description provided.