Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: #227: scaffolder option no redux #268

Conversation

dannd4
Copy link
Contributor

@dannd4 dannd4 commented Feb 13, 2020

No description provided.

@github-actions github-actions bot added the react-app-scaffolder Relates to React App Scaffolder package label Feb 13, 2020
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am approving because I don't want to block you but please remove the debugger before merging. Nice work 👍


if (refreshParams && !hasSession) {
setRefreshSession(refreshParams)
return null
}

if (!hasSession) {
debugger
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debugger left in

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dannd4 dannd4 force-pushed the chore/227-scaffolder-option-no-redux branch from bdb4bc4 to 6874063 Compare February 13, 2020 15:31
@willmcvay willmcvay merged commit de461f2 into chore/33-update-react-scalfolder Feb 13, 2020
@willmcvay willmcvay deleted the chore/227-scaffolder-option-no-redux branch February 13, 2020 15:53
willmcvay pushed a commit that referenced this pull request Feb 14, 2020
* temp

* temp

* chore: #33 update marketplace-api-schema.ts file

* chore: #230 Update scaffolder styles solutions (#259)

* temp

* temp

* chore: #230 Update scaffolder styles solutions

* chore: #230 Update .gitignore

* chore: #230 update types file

Co-authored-by: NghiaPham <[email protected]>

* chore: #227: scaffolder option no redux (#268)

* chore: #244 Update base files of the scaffolder

* fix .gitignore

* update schema file

* update snapshot

Co-authored-by: Khac Vy <[email protected]>
Co-authored-by: Dan Nguyen <[email protected]>
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
)

* [CLD-685] Update the UI for the Help page on the Developers Portal

* Remove unnecessary prop type

* Add key prop

* Using @reapit/elements instead
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
* temp

* temp

* chore: #33 update marketplace-api-schema.ts file

* chore: #230 Update scaffolder styles solutions (#259)

* temp

* temp

* chore: #230 Update scaffolder styles solutions

* chore: #230 Update .gitignore

* chore: #230 update types file

Co-authored-by: NghiaPham <[email protected]>

* chore: #227: scaffolder option no redux (#268)

* chore: #244 Update base files of the scaffolder

* fix .gitignore

* update schema file

* update snapshot

Co-authored-by: Khac Vy <[email protected]>
Co-authored-by: Dan Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
react-app-scaffolder Relates to React App Scaffolder package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants