Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subtask of #33: Update base files location, and package.json scripts #244

Closed
phmngocnghia opened this issue Feb 12, 2020 · 0 comments
Closed

Subtask of #33: Update base files location, and package.json scripts #244

phmngocnghia opened this issue Feb 12, 2020 · 0 comments
Assignees
@nphivu414 @phmngocnghia

Comments

@phmngocnghia
Copy link
Contributor

phmngocnghia commented Feb 12, 2020 •
edited
Loading

Files that are useable need to be placed to their desired location (base,base-is-foundation, base-is-not-foundation)
E.g. Index.html, webpack, tsconfig

Need a script added to release this package to production (refer to other NPM packages - elements, cognito)
@phmngocnghia phmngocnghia changed the title Subtask of #33: Update base files location Subtask of #33: Update base files location, and package.json scripts Feb 12, 2020
@duong-se duong-se assigned duong-se and unassigned duong-se Feb 12, 2020
@nphivu414 nphivu414 self-assigned this Feb 13, 2020
@nphivu414 nphivu414 linked a pull request Feb 14, 2020 that will close this issue
[WIP] Chore/244 update base file location #280
Closed
phmngocnghia pushed a commit that referenced this issue Feb 14, 2020
@nphivu414 @phmngocnghia
feat: #244 - Update page title - fix invalid file name
850c292
phmngocnghia added a commit that referenced this issue Feb 14, 2020
@phmngocnghia
chore: #244 Update base files of the scaffolder
a8899c1
willmcvay pushed a commit that referenced this issue Feb 14, 2020
@trankhacvy @dannd4
[WIP]Chore/33 update react scalfolder (#224)
03e2db4 
* temp

* temp

* chore: #33 update marketplace-api-schema.ts file

* chore: #230 Update scaffolder styles solutions (#259)

* temp

* temp

* chore: #230 Update scaffolder styles solutions

* chore: #230 Update .gitignore

* chore: #230 update types file

Co-authored-by: NghiaPham <[email protected]>

* chore: #227: scaffolder option no redux (#268)

* chore: #244 Update base files of the scaffolder

* fix .gitignore

* update schema file

* update snapshot

Co-authored-by: Khac Vy <[email protected]>
Co-authored-by: Dan Nguyen <[email protected]>
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
@vuhuucuong
[CLD-620] Fix success message not shown (#244)
1b45ffb 
[CLD-620] Fix success message not shown when resetting password (#244)
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
@trankhacvy @dannd4
[WIP]Chore/33 update react scalfolder (#224)
f90cefe 
* temp

* temp

* chore: #33 update marketplace-api-schema.ts file

* chore: #230 Update scaffolder styles solutions (#259)

* temp

* temp

* chore: #230 Update scaffolder styles solutions

* chore: #230 Update .gitignore

* chore: #230 update types file

Co-authored-by: NghiaPham <[email protected]>

* chore: #227: scaffolder option no redux (#268)

* chore: #244 Update base files of the scaffolder

* fix .gitignore

* update schema file

* update snapshot

Co-authored-by: Khac Vy <[email protected]>
Co-authored-by: Dan Nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nphivu414 nphivu414

@phmngocnghia phmngocnghia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Chore/244 update base file location reapit/foundations
4 participants
@willmcvay @nphivu414 @duong-se @phmngocnghia